[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/8] cpus: Move do_run_on_cpu into softmmu/cpus.c
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v3 2/8] cpus: Move do_run_on_cpu into softmmu/cpus.c |
|
Date: |
Wed, 28 Jul 2021 20:35:15 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 7/28/21 8:31 PM, Peter Xu wrote:
> It's only used by softmmu binaries not linux-user ones. Make it static and
> drop the definition in the header too.
>
> Since at it, initialize variable "wi" with less loc.
>
> Reviewed-by: David Hildenbrand <david@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> cpus-common.c | 25 -------------------------
> include/hw/core/cpu.h | 12 ------------
> softmmu/cpus.c | 23 +++++++++++++++++++++++
> 3 files changed, 23 insertions(+), 37 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH v3 0/8] memory: Sanity checks memory transaction when releasing BQL, Peter Xu, 2021/07/28
- [PATCH v3 1/8] cpus: Export queue work related fields to cpu.h, Peter Xu, 2021/07/28
- [PATCH v3 3/8] memory: Introduce memory_region_transaction_depth_{inc|dec}(), Peter Xu, 2021/07/28
- [PATCH v3 2/8] cpus: Move do_run_on_cpu into softmmu/cpus.c, Peter Xu, 2021/07/28
- Re: [PATCH v3 2/8] cpus: Move do_run_on_cpu into softmmu/cpus.c,
Philippe Mathieu-Daudé <=
- [PATCH v3 4/8] memory: Don't do topology update in memory finalize(), Peter Xu, 2021/07/28
- [PATCH v3 5/8] cpus: Use qemu_cond_wait_iothread() where proper, Peter Xu, 2021/07/28
- [PATCH v3 6/8] cpus: Remove the mutex parameter from do_run_on_cpu(), Peter Xu, 2021/07/28
- [PATCH v3 8/8] memory: Delay the transaction pop() until commit completed, Peter Xu, 2021/07/28
- [PATCH v3 7/8] memory: Assert on no ongoing memory transaction before release BQL, Peter Xu, 2021/07/28