[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC server 04/11] vfio-user: find and init PCI device
From: |
Jag Raman |
Subject: |
Re: [PATCH RFC server 04/11] vfio-user: find and init PCI device |
Date: |
Wed, 28 Jul 2021 17:08:39 +0000 |
> On Jul 26, 2021, at 11:05 AM, John Levon <levon@movementarian.org> wrote:
>
> On Mon, Jul 19, 2021 at 04:00:06PM -0400, Jagannathan Raman wrote:
>
>> + vfu_pci_set_id(o->vfu_ctx,
>> + pci_get_word(o->pci_dev->config + PCI_VENDOR_ID),
>> + pci_get_word(o->pci_dev->config + PCI_DEVICE_ID),
>> + pci_get_word(o->pci_dev->config +
>> PCI_SUBSYSTEM_VENDOR_ID),
>> + pci_get_word(o->pci_dev->config + PCI_SUBSYSTEM_ID));
>
> Since you handle all config space accesses yourselves, is there even any need
> for this?
I think that makes sense. Since the QEMU server handles all the config space
accesses, it’s not necessary to register the device’s vendor/device ID with the
library.
Thank you!
--
Jag
>
> regards
> john
- RE: [PATCH RFC server 11/11] vfio-user: acceptance test, (continued)
[PATCH RFC server 03/11] vfio-user: instantiate vfio-user context, Jagannathan Raman, 2021/07/19
[PATCH RFC server 02/11] vfio-user: define vfio-user object, Jagannathan Raman, 2021/07/19
[PATCH RFC server 04/11] vfio-user: find and init PCI device, Jagannathan Raman, 2021/07/19
[PATCH RFC server 06/11] vfio-user: handle PCI config space accesses, Jagannathan Raman, 2021/07/19
[PATCH RFC server 05/11] vfio-user: run vfio-user context, Jagannathan Raman, 2021/07/19