[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-6.2 v3 07/11] machine: Use ms instead of global current_m
From: |
Pankaj Gupta |
Subject: |
Re: [PATCH for-6.2 v3 07/11] machine: Use ms instead of global current_machine in sanity-check |
Date: |
Wed, 28 Jul 2021 06:37:23 +0200 |
> In the sanity-check of smp_cpus and max_cpus against mc in function
> machine_set_smp(), we are now using ms->smp.max_cpus for the check
> but using current_machine->smp.max_cpus in the error message.
> Tweak this by uniformly using the local ms.
>
> Reviewed-by: Andrew Jones <drjones@redhat.com>
> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
> ---
> hw/core/machine.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index a8173a0f45..e13a8f2f34 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -878,7 +878,7 @@ static void machine_set_smp(Object *obj, Visitor *v,
> const char *name,
> } else if (ms->smp.max_cpus > mc->max_cpus) {
> error_setg(errp, "Invalid SMP CPUs %d. The max CPUs "
> "supported by machine '%s' is %d",
> - current_machine->smp.max_cpus,
> + ms->smp.max_cpus,
> mc->name, mc->max_cpus);
> }
>
Reviewed-by: Pankaj Gupta <pankaj.gupta@ionos.com>
- [PATCH for-6.2 v3 00/11] machine: smp parsing fixes and improvement, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 05/11] hw: Add compat machines for 6.2, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 01/11] machine: Minor refactor/cleanup for the smp parsers, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 08/11] machine: Tweak the order of topology members in struct CpuTopology, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 04/11] machine: Improve the error reporting of smp parsing, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 02/11] machine: Uniformly use maxcpus to calculate the omitted parameters, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 07/11] machine: Use ms instead of global current_machine in sanity-check, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 10/11] machine: Remove smp_parse callback from MachineClass, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 09/11] machine: Make smp_parse generic enough for all arches, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 03/11] machine: Set the value of cpus to match maxcpus if it's omitted, Yanan Wang, 2021/07/27
- [PATCH for-6.2 v3 06/11] machine: Prefer cores over sockets in smp parsing since 6.2, Yanan Wang, 2021/07/27