[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH-for-6.1 v5 3/4] gitlab-ci: Fix 'when:' condition in EDK2 jobs
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH-for-6.1 v5 3/4] gitlab-ci: Fix 'when:' condition in EDK2 jobs |
Date: |
Tue, 27 Jul 2021 16:24:30 +0200 |
Jobs depending on another should not use the 'when: always'
condition, because if a dependency failed we should not keep
running jobs depending on it. The correct condition is
'when: on_success'.
Fixes: 71920809cea ("gitlab-ci.yml: Add jobs to build EDK2 firmware binaries")
Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
.gitlab-ci.d/edk2.yml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/.gitlab-ci.d/edk2.yml b/.gitlab-ci.d/edk2.yml
index aae2f7ad880..62497ba47fb 100644
--- a/.gitlab-ci.d/edk2.yml
+++ b/.gitlab-ci.d/edk2.yml
@@ -8,11 +8,11 @@
- .gitlab-ci.d/edk2/Dockerfile
# or roms/edk2/ is modified (submodule updated)
- roms/edk2/*
- when: always
+ when: on_success
- if: '$CI_COMMIT_REF_NAME =~ /^edk2/' # or the branch/tag starts with 'edk2'
- when: always
+ when: on_success
- if: '$CI_COMMIT_MESSAGE =~ /edk2/i' # or last commit description contains
'EDK2'
- when: always
+ when: on_success
docker-edk2:
extends: .edk2_job_rules
--
2.31.1
- [PATCH-for-6.1 v5 0/4] gitlab-ci: Document custom CI/CD variables, fix 'when:' conditions, Philippe Mathieu-Daudé, 2021/07/27
- [PATCH-for-6.1 v5 2/4] gitlab-ci: Fix 'when:' condition in acceptance_test_job_template, Philippe Mathieu-Daudé, 2021/07/27
- [PATCH-for-6.1 v5 1/4] docs: Document GitLab custom CI/CD variables, Philippe Mathieu-Daudé, 2021/07/27
- [PATCH-for-6.1 v5 3/4] gitlab-ci: Fix 'when:' condition in EDK2 jobs,
Philippe Mathieu-Daudé <=
- [PATCH-for-6.1 v5 4/4] gitlab-ci: Fix 'when:' condition in OpenSBI jobs, Philippe Mathieu-Daudé, 2021/07/27
- Re: [PATCH-for-6.1 v5 0/4] gitlab-ci: Document custom CI/CD variables, fix 'when:' conditions, Thomas Huth, 2021/07/27