[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Regression caught by replay_kernel.py:ReplayKernelNormal.test_aarch6
From: |
Cleber Rosa |
Subject: |
Re: Regression caught by replay_kernel.py:ReplayKernelNormal.test_aarch64_virt |
Date: |
Tue, 27 Jul 2021 09:18:24 -0400 |
On Tue, Jul 27, 2021 at 3:37 AM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Tue, 27 Jul 2021 at 01:39, Cleber Rosa <crosa@redhat.com> wrote:
> >
> >
> > Hi everyone,
> >
> > tests/acceptance/replay_kernel.py:ReplayKernelNormal.test_aarch64_virt
> > is currently failing consistently (first found that in [1]).
> >
> > I've bisected it down to the following commit:
> >
> > ---
> >
> > 78ff82bb1b67c0d79113688e4b3427fc99cab9d4 is the first bad commit
> > commit 78ff82bb1b67c0d79113688e4b3427fc99cab9d4
> > Author: Richard Henderson <richard.henderson@linaro.org>
> >
> > accel/tcg: Reduce CF_COUNT_MASK to match TCG_MAX_INSNS
> >
> > The space reserved for CF_COUNT_MASK was overly large.
> > Reduce to free up cflags bits and eliminate an extra test.
> >
> > Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> > Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> > Message-Id: <20210717221851.2124573-2-richard.henderson@linaro.org>
> >
> > accel/tcg/translate-all.c | 5 ++---
> > include/exec/exec-all.h | 4 +++-
> > 2 files changed, 5 insertions(+), 4 deletions(-)
>
> This is probably fixed by
> 20210725174405.24568-1-peter.maydell@linaro.org/">https://patchew.org/QEMU/20210725174405.24568-1-peter.maydell@linaro.org/
> (which is in RTH's pullreq currently on list).
>
> -- PMM
>
Actually, it is already fixed by df3a2de51a07089a4a729fe1f792f658df9dade4.
BTW, TCG looks like the right place where the bug was, because it
affected other targets and machines. This is the actual list of tests
I was seeing the same issue (and are now fixed):
(1/4) tests/acceptance/replay_kernel.py:ReplayKernelNormal.test_aarch64_virt:
PASS (8.86 s)
(2/4) tests/acceptance/replay_kernel.py:ReplayKernelNormal.test_arm_virt:
PASS (13.42 s)
(3/4) tests/acceptance/replay_kernel.py:ReplayKernelNormal.test_m68k_mcf5208evb:
PASS (3.20 s)
(4/4) tests/acceptance/replay_kernel.py:ReplayKernelNormal.test_xtensa_lx60:
PASS (12.29 s)
Cheers,
- Cleber.