[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/qtest/migration-test.c: use 127.0.0.1 instead of 0
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH] tests/qtest/migration-test.c: use 127.0.0.1 instead of 0 |
Date: |
Mon, 26 Jul 2021 12:26:28 +0100 |
User-agent: |
Mutt/2.0.7 (2021-05-04) |
* Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1
> in baddest; it's really testing the :0 port number that isn't allowed
> on anything.
>
> (The test doesn't currently run anyway because of the userfault
> problem that Peter noticed, but this gets us closer to being able to
> reenable it)
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Queued
> ---
> tests/qtest/migration-test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index 328d6dbe97..1e8b7784ef 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -787,10 +787,10 @@ static void test_baddest(void)
>
> args->hide_stderr = true;
>
> - if (test_migrate_start(&from, &to, "tcp:0:0", args)) {
> + if (test_migrate_start(&from, &to, "tcp:127.0.0.1:0", args)) {
> return;
> }
> - migrate_qmp(from, "tcp:0:0", "{}");
> + migrate_qmp(from, "tcp:127.0.0.1:0", "{}");
> wait_for_migration_fail(from, false);
> test_migrate_end(from, to, false);
> }
> --
> 2.31.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK