[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-6.1? v2 7/9] hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_
From: |
Richard Henderson |
Subject: |
[PATCH for-6.1? v2 7/9] hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_write |
Date: |
Sun, 25 Jul 2021 02:24:14 -1000 |
>From clang-13:
hw/pci-host/pnv_phb4.c:375:18: error: variable 'v' set but not used \
[-Werror,-Wunused-but-set-variable]
It's pretty clear that we meant to write back 'v' after
all that computation and not 'val'.
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
hw/pci-host/pnv_phb4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c
index 54f57c660a..5c375a9f28 100644
--- a/hw/pci-host/pnv_phb4.c
+++ b/hw/pci-host/pnv_phb4.c
@@ -392,7 +392,7 @@ static void pnv_phb4_ioda_write(PnvPHB4 *phb, uint64_t val)
v &= 0xffffffffffff0000ull;
v |= 0x000000000000cfffull & val;
}
- *tptr = val;
+ *tptr = v;
break;
}
case IODA3_TBL_MBT:
--
2.25.1
- [PATCH for-6.1? v2 1/9] nbd/server: Mark variable unused in nbd_negotiate_meta_queries, (continued)
- [PATCH for-6.1? v2 1/9] nbd/server: Mark variable unused in nbd_negotiate_meta_queries, Richard Henderson, 2021/07/25
- [PATCH for-6.1? v2 2/9] accel/tcg: Remove unused variable in cpu_exec, Richard Henderson, 2021/07/25
- [PATCH for-6.1? v2 4/9] net/checksum: Remove unused variable in net_checksum_add_iov, Richard Henderson, 2021/07/25
- [PATCH for-6.1? v2 3/9] util/selfmap: Discard mapping on error, Richard Henderson, 2021/07/25
- [PATCH for-6.1? v2 5/9] hw/audio/adlib: Remove unused variable in adlib_callback, Richard Henderson, 2021/07/25
- [PATCH for-6.1? v2 6/9] hw/ppc/spapr_events: Remove unused variable from check_exception, Richard Henderson, 2021/07/25
- [PATCH for-6.1? v2 7/9] hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_write,
Richard Henderson <=
- [PATCH for-6.1? v2 8/9] linux-user/syscall: Remove unused variable from execve, Richard Henderson, 2021/07/25
- [PATCH for-6.1? v2 9/9] tests/unit: Remove unused variable from test_io, Richard Henderson, 2021/07/25
- Re: [PATCH for-6.1? v2 0/9] Fixes for clang-13, Richard Henderson, 2021/07/26