[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH resend v2 1/5] tpm: mark correct memory region range dirty wh
From: |
Peter Xu |
Subject: |
Re: [PATCH resend v2 1/5] tpm: mark correct memory region range dirty when clearing RAM |
Date: |
Fri, 23 Jul 2021 10:52:42 -0400 |
On Tue, Jul 20, 2021 at 03:03:00PM +0200, David Hildenbrand wrote:
> @@ -30,11 +30,13 @@ void tpm_ppi_reset(TPMPPI *tpmppi)
> guest_phys_blocks_init(&guest_phys_blocks);
> guest_phys_blocks_append(&guest_phys_blocks);
> QTAILQ_FOREACH(block, &guest_phys_blocks.head, next) {
> + ram_addr_t mr_start = memory_region_get_ram_addr(block->mr);
> +
> trace_tpm_ppi_memset(block->host_addr,
> block->target_end - block->target_start);
> memset(block->host_addr, 0,
> block->target_end - block->target_start);
> - memory_region_set_dirty(block->mr, 0,
> + memory_region_set_dirty(block->mr, block->target_start -
> mr_start,
> block->target_end - block->target_start);
target_start should falls in gpa range, while mr_start is ram_addr_t. I am not
sure whether this is right..
Neither do I know how to get correct mr offset with the existing info we've got
from GuestPhysBlock. Maybe we need to teach guest_phys_blocks_region_add() to
also record section->offset_within_region?
--
Peter Xu
[PATCH resend v2 2/5] softmmu/memory_mapping: reuse qemu_get_guest_simple_memory_mapping(), David Hildenbrand, 2021/07/20
[PATCH resend v2 3/5] softmmu/memory_mapping: never merge ranges accross memory regions, David Hildenbrand, 2021/07/20