[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/1] modules: Improve error message when module is not fou
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH v2 1/1] modules: Improve error message when module is not found |
Date: |
Fri, 23 Jul 2021 14:48:58 +0200 |
> > bool have_tcg = accel_find("tcg");
> >
> > return true when the code is actually not there, there seems to be a larger
> > issue to solve.
> >
> > I think we need to think more broadly about this.
>
> Overall, building the whole code base to be modular,
> and then _not_ including unwanted modules in the base distro package,
> is the whole point of going through this at all.
Yes.
Right now we are only half-through. tcg-accel-ops is modular, but
tcg-accel is not (yet). Which I guess is why the assert() can trigger
now.
So add a patch with error message and a FIXME comment, which we can
revert when isn't needed any more?
> So we need more work to make this actually work right.
Yes. I want have all of tcg in the tcg accel module, not only parts of
it, but that needs some more refactoring. I'll go start looking at this
once I managed to wade through my vacation backlog.
take care,
Gerd
- [PATCH v2 0/1] Improve module accelerator error message, Jose R. Ziviani, 2021/07/22
- [PATCH v2 1/1] modules: Improve error message when module is not found, Jose R. Ziviani, 2021/07/22
- Re: [PATCH v2 1/1] modules: Improve error message when module is not found, Gerd Hoffmann, 2021/07/23
- Re: [PATCH v2 1/1] modules: Improve error message when module is not found, Markus Armbruster, 2021/07/23
- Re: [PATCH v2 1/1] modules: Improve error message when module is not found, Claudio Fontana, 2021/07/23
- Re: [PATCH v2 1/1] modules: Improve error message when module is not found, Gerd Hoffmann, 2021/07/23
- Re: [PATCH v2 1/1] modules: Improve error message when module is not found, Claudio Fontana, 2021/07/23
- Re: [PATCH v2 1/1] modules: Improve error message when module is not found, Claudio Fontana, 2021/07/23
- Re: [PATCH v2 1/1] modules: Improve error message when module is not found,
Gerd Hoffmann <=
- modular tcg (was: Re: [PATCH v2 1/1] modules: Improve error message when module is not) found, Gerd Hoffmann, 2021/07/29
- Re: modular tcg, Claudio Fontana, 2021/07/29
- Re: modular tcg, Gerd Hoffmann, 2021/07/29
- Re: modular tcg, Claudio Fontana, 2021/07/29
- Re: modular tcg, Claudio Fontana, 2021/07/29
- Re: modular tcg, Gerd Hoffmann, 2021/07/29
- Re: modular tcg, Claudio Fontana, 2021/07/29
- Re: modular tcg, Philippe Mathieu-Daudé, 2021/07/29
- Re: modular tcg, Claudio Fontana, 2021/07/29
- Re: modular tcg, Claudio Fontana, 2021/07/29