[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/6] hw/display: fail early when multiple virgl devices are reques
From: |
Gerd Hoffmann |
Subject: |
[PULL 4/6] hw/display: fail early when multiple virgl devices are requested |
Date: |
Fri, 23 Jul 2021 07:54:46 +0200 |
From: Marc-André Lureau <marcandre.lureau@redhat.com>
This avoids failing to initialize virgl and crashing later on, and clear
the user expectations.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Message-Id: <20210705104218.1161101-1-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/display/virtio-gpu-gl.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/display/virtio-gpu-gl.c b/hw/display/virtio-gpu-gl.c
index 7ab93bf8c829..b1035e119c3b 100644
--- a/hw/display/virtio-gpu-gl.c
+++ b/hw/display/virtio-gpu-gl.c
@@ -113,6 +113,11 @@ static void virtio_gpu_gl_device_realize(DeviceState
*qdev, Error **errp)
return;
#endif
+ if (!object_resolve_path_type("", TYPE_VIRTIO_GPU_GL, NULL)) {
+ error_setg(errp, "at most one %s device is permitted",
TYPE_VIRTIO_GPU_GL);
+ return;
+ }
+
if (!display_opengl) {
error_setg(errp, "opengl is not available");
return;
--
2.31.1
- [PULL 0/6] Vga 20210723 patches, Gerd Hoffmann, 2021/07/23
- [PULL 1/6] hw/display/virtio-gpu: Fix memory leak (CID 1453811), Gerd Hoffmann, 2021/07/23
- [PULL 2/6] qxl: remove assert in qxl_pre_save., Gerd Hoffmann, 2021/07/23
- [PULL 4/6] hw/display: fail early when multiple virgl devices are requested,
Gerd Hoffmann <=
- [PULL 3/6] Revert "qxl: add migration blocker to avoid pre-save assert", Gerd Hoffmann, 2021/07/23
- [PULL 5/6] vl: add virtio-vga-gl to the default_list, Gerd Hoffmann, 2021/07/23
- [PULL 6/6] hw/display: fix virgl reset regression, Gerd Hoffmann, 2021/07/23
- Re: [PULL 0/6] Vga 20210723 patches, Peter Maydell, 2021/07/23