[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/15] vl: Parse legacy default_machine_opts
From: |
Paolo Bonzini |
Subject: |
[PULL 03/15] vl: Parse legacy default_machine_opts |
Date: |
Thu, 22 Jul 2021 17:36:00 +0200 |
From: Jason Andryuk <jandryuk@gmail.com>
qemu can't start a xen vm after commit d8fb7d0969d5
"vl: switch -M parsing to keyval" with:
$ ./qemu-system-i386 -M xenfv
Unexpected error in object_property_find_err() at ../qom/object.c:1298:
qemu-system-i386: Property 'xenfv-3.1-machine.accel' not found
Aborted (core dumped)
The default_machine_opts handling doesn't process the legacy machine
options like "accel". Call qemu_apply_legacy_machine_options to provide
the legacy handling.
Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
Message-Id: <20210713021552.19110-1-jandryuk@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
softmmu/vl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 4df1496101..f4d8630fc6 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -2126,6 +2126,7 @@ static void qemu_create_machine(QDict *qdict)
QDict *default_opts =
keyval_parse(machine_class->default_machine_opts, NULL, NULL,
&error_abort);
+ qemu_apply_legacy_machine_options(default_opts);
object_set_properties_from_keyval(OBJECT(current_machine),
default_opts,
false, &error_abort);
qobject_unref(default_opts);
--
2.31.1
- [PULL 06/15] qemu-config: restore "machine" in qmp_query_command_line_options(), (continued)
- [PULL 06/15] qemu-config: restore "machine" in qmp_query_command_line_options(), Paolo Bonzini, 2021/07/22
- [PULL 09/15] target/i386: Added consistency checks for EFER, Paolo Bonzini, 2021/07/22
- [PULL 08/15] target/i386: Added consistency checks for CR4, Paolo Bonzini, 2021/07/22
- [PULL 04/15] chardev-spice: add missing module_obj directive, Paolo Bonzini, 2021/07/22
- [PULL 02/15] qemu-config: fix memory leak on ferror(), Paolo Bonzini, 2021/07/22
- [PULL 11/15] meson: fix dependencies for modinfo, Paolo Bonzini, 2021/07/22
- [PULL 10/15] configure: Drop obsolete check for the alloc_size attribute, Paolo Bonzini, 2021/07/22
- [PULL 13/15] configure: Allow vnc to get disabled with --without-default-features, Paolo Bonzini, 2021/07/22
- [PULL 15/15] configure: Let --without-default-features disable vhost-kernel and vhost-vdpa, Paolo Bonzini, 2021/07/22
- [PULL 03/15] vl: Parse legacy default_machine_opts,
Paolo Bonzini <=
- [PULL 07/15] target/i386: Added V_INTR_PRIO check to virtual interrupts, Paolo Bonzini, 2021/07/22
- [PULL 05/15] usb: fix usb-host dependency check, Paolo Bonzini, 2021/07/22
- [PULL 14/15] configure: Fix the default setting of the "xen" feature, Paolo Bonzini, 2021/07/22
- [PULL 12/15] configure: Fix --without-default-features propagation to meson, Paolo Bonzini, 2021/07/22
- Re: [PULL 00/15] Misc bugfix patches for 2021-07-22, Peter Maydell, 2021/07/23