qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-6.1 0/1] machine: Disallow specifying topology parameters


From: Paolo Bonzini
Subject: Re: [PATCH for-6.1 0/1] machine: Disallow specifying topology parameters as zero
Date: Thu, 22 Jul 2021 15:55:40 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 22/07/21 15:37, Andrew Jones wrote:
This doesn't mention zero inputs and even implies non-zero inputs.

I'm not sure if we need to worry about the odd command line that used zero
for some parameters. What do you think?

I think I agree as well, however the patch that Yanan sent has unnecessary duplication between smp_parse and pc_smp_parse. machine_set_smp is a better place to implement this kind of check.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]