[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3] migration: clear the memory region dirty bitmap when skip
From: |
Wang, Wei W |
Subject: |
RE: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages |
Date: |
Thu, 22 Jul 2021 09:57:13 +0000 |
On Thursday, July 22, 2021 5:48 PM, David Hildenbrand wrote:
> On 22.07.21 10:30, Wei Wang wrote:
> > When skipping free pages to send, their corresponding dirty bits in
> > the memory region dirty bitmap need to be cleared. Otherwise the
> > skipped pages will be sent in the next round after the migration
> > thread syncs dirty bits from the memory region dirty bitmap.
> >
> > Cc: David Hildenbrand <david@redhat.com>
> > Cc: Peter Xu <peterx@redhat.com>
> > Cc: Michael S. Tsirkin <mst@redhat.com>
> > Reported-by: David Hildenbrand <david@redhat.com>
> > Signed-off-by: Wei Wang <wei.w.wang@intel.com>
> > ---
> > migration/ram.c | 74
> +++++++++++++++++++++++++++++++++++++------------
> > 1 file changed, 56 insertions(+), 18 deletions(-)
> >
>
> LGTM, thanks
>
> Reviewed-by: David Hildenbrand <david@redhat.com>
>
Thanks. Please remember to have a regression test together with Peterx's that
patch when you get a chance.
Best,
Wei
- [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages, Wei Wang, 2021/07/22
- Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages, David Hildenbrand, 2021/07/22
- RE: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages,
Wang, Wei W <=
- Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages, Peter Xu, 2021/07/22
- Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages, David Hildenbrand, 2021/07/22
- Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages, Peter Xu, 2021/07/22
- Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages, David Hildenbrand, 2021/07/23
- RE: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages, Wang, Wei W, 2021/07/23
- Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages, David Hildenbrand, 2021/07/23
- RE: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages, Wang, Wei W, 2021/07/23
- Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages, Peter Xu, 2021/07/23
- Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages, David Hildenbrand, 2021/07/23
- Re: [PATCH v3] migration: clear the memory region dirty bitmap when skipping free pages, David Hildenbrand, 2021/07/23