[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/16] whpx nvmm: Drop useless migrate_del_blocker()
From: |
Reinoud Zandijk |
Subject: |
Re: [PATCH 08/16] whpx nvmm: Drop useless migrate_del_blocker() |
Date: |
Thu, 22 Jul 2021 10:04:32 +0200 |
On Tue, Jul 20, 2021 at 02:54:00PM +0200, Markus Armbruster wrote:
> There is nothing to delete after migrate_add_blocker() failed. Trying
> anyway is safe, but useless. Don't.
>
> Cc: Sunil Muthuswamy <sunilmut@microsoft.com>
> Cc: Kamil Rytarowski <kamil@netbsd.org>
> Cc: Reinoud Zandijk <reinoud@netbsd.org>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> target/i386/nvmm/nvmm-all.c | 1 -
> target/i386/whpx/whpx-all.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c
> index dfa690d65d..7bb0d9e30e 100644
> --- a/target/i386/nvmm/nvmm-all.c
> +++ b/target/i386/nvmm/nvmm-all.c
> @@ -929,7 +929,6 @@ nvmm_init_vcpu(CPUState *cpu)
> (void)migrate_add_blocker(nvmm_migration_blocker, &local_error);
> if (local_error) {
> error_report_err(local_error);
> - migrate_del_blocker(nvmm_migration_blocker);
> error_free(nvmm_migration_blocker);
> return -EINVAL;
> }
Reviewed-by: Reinoud Zandijk <reinoud@NetBSD.org>
No problem with it
- [PATCH 06/16] i386: Never free migration blocker objects instead of sometimes, (continued)
- [PATCH 06/16] i386: Never free migration blocker objects instead of sometimes, Markus Armbruster, 2021/07/20
- [PATCH 09/16] migration: Unify failure check for migrate_add_blocker(), Markus Armbruster, 2021/07/20
- [PATCH 10/16] migration: Handle migration_incoming_setup() errors consistently, Markus Armbruster, 2021/07/20
- [PATCH 03/16] spapr: Explain purpose of ->fwnmi_migration_blocker more clearly, Markus Armbruster, 2021/07/20
- [PATCH 08/16] whpx nvmm: Drop useless migrate_del_blocker(), Markus Armbruster, 2021/07/20
- Re: [PATCH 08/16] whpx nvmm: Drop useless migrate_del_blocker(),
Reinoud Zandijk <=
- [PATCH 07/16] vfio: Avoid error_propagate() after migrate_add_blocker(), Markus Armbruster, 2021/07/20
- [PATCH 05/16] vhost-scsi: Plug memory leak on migrate_add_blocker() failure, Markus Armbruster, 2021/07/20
- [PATCH 11/16] microvm: Drop dead error handling in microvm_machine_state_init(), Markus Armbruster, 2021/07/20