Re: [PATCH for-6.2 v2 00/11] machine: smp parsing fixes and improvement

[Pierre Morel]

On 7/21/21 2:38 PM, wangyanan (Y) wrote:
> On 2021/7/20 0:57, Cornelia Huck wrote:
> > On Mon, Jul 19 2021, Yanan Wang <wangyanan55@huawei.com> wrote:
> >
> > > Hi,
> > >
> > > This is v2 of the series [1] that I have posted to introduce some smp 
> > > parsing
> > > fixes and improvement, much more work has been processed compared to 
> > > RFC v1.
> > >
> > > [1] https://lists.gnu.org/archive/html/qemu-devel/2021-07/msg00259.html
> > >
> > > The purpose of this series is to improve/fix the parsing logic. 
> > > Explicitly
> > > specifying a CPU topology parameter as zero is not allowed any more, and
> > > maxcpus is now uniformly used to calculate the omitted parameters. 
> > > It's also
> > > suggested that we should start to prefer cores over sockets over 
> > > threads on
> > > the newer machine types, which will make the computed virtual 
> > > topology more
> > > reflective of the real hardware.
> > >
> > > In order to reduce code duplication and ease the code maintenance, 
> > > smp_parse
> > > in now converted into a parser generic enough for all arches, so that 
> > > the PC
> > > specific one can be removed. It's also convenient to introduce more 
> > > topology
> > > members (e.g. cluster) to the generic parser in the future.
> > Cc:ing Pierre, as he also had been looking at the smp parsing code (for
> > s390x) recently.
> >
> > Also, please keep me on cc: for patches that touch s390x.
> Sure, I will. Sorry about the missing. :)
>
> Thanks,
> Yanan
> .
And me too please.
Thanks
Pierre

--
Pierre Morel
IBM Lab Boeblingen