[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 12/13] tests/plugins/syscalls: adhere to new arg-passing schem
From: |
Mahmoud Mandour |
Subject: |
[PATCH v3 12/13] tests/plugins/syscalls: adhere to new arg-passing scheme |
Date: |
Thu, 22 Jul 2021 09:12:35 +0200 |
Signed-off-by: Mahmoud Mandour <ma.mandourr@gmail.com>
---
tests/plugin/syscall.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/tests/plugin/syscall.c b/tests/plugin/syscall.c
index 6dd71092e1..484b48de49 100644
--- a/tests/plugin/syscall.c
+++ b/tests/plugin/syscall.c
@@ -119,17 +119,26 @@ QEMU_PLUGIN_EXPORT int
qemu_plugin_install(qemu_plugin_id_t id,
const qemu_info_t *info,
int argc, char **argv)
{
- if (argc == 0) {
- statistics = g_hash_table_new_full(NULL, g_direct_equal, NULL, g_free);
- } else {
- for (int i = 0; i < argc; i++) {
- if (g_strcmp0(argv[i], "print") != 0) {
- fprintf(stderr, "unsupported argument: %s\n", argv[i]);
- return -1;
+ bool do_print = false;
+
+ for (int i = 0; i < argc; i++) {
+ char *opt = argv[i];
+ g_autofree char **tokens = g_strsplit(opt, "=", 2);
+
+ if (g_strcmp0(tokens[0], "print") == 0) {
+ if (!qemu_plugin_bool_parse(tokens[0], tokens[1], &do_print)) {
+ fprintf(stderr, "boolean argument parsing failed: %s\n", opt);
}
+ } else {
+ fprintf(stderr, "unsupported argument: %s\n", argv[i]);
+ return -1;
}
}
+ if (!do_print) {
+ statistics = g_hash_table_new_full(NULL, g_direct_equal, NULL, g_free);
+ }
+
qemu_plugin_register_vcpu_syscall_cb(id, vcpu_syscall);
qemu_plugin_register_vcpu_syscall_ret_cb(id, vcpu_syscall_ret);
qemu_plugin_register_atexit_cb(id, plugin_exit, NULL);
--
2.25.1
- [PATCH v3 01/13] plugins: allow plugin arguments to be passed directly, (continued)
- [PATCH v3 01/13] plugins: allow plugin arguments to be passed directly, Mahmoud Mandour, 2021/07/22
- [PATCH v3 03/13] plugins/hotpages: introduce sortby arg and parsed bool args correctly, Mahmoud Mandour, 2021/07/22
- [PATCH v3 04/13] plugins/hotblocks: Added correct boolean argument parsing, Mahmoud Mandour, 2021/07/22
- [PATCH v3 05/13] plugins/lockstep: make socket path not positional & parse bool arg, Mahmoud Mandour, 2021/07/22
- [PATCH v3 06/13] plugins/hwprofile: adapt to the new plugin arguments scheme, Mahmoud Mandour, 2021/07/22
- [PATCH v3 07/13] plugins/howvec: Adapting to the new argument passing scheme., Mahmoud Mandour, 2021/07/22
- [PATCH v3 08/13] docs/tcg-plugins: new passing parameters scheme for cache docs, Mahmoud Mandour, 2021/07/22
- [PATCH v3 09/13] tests/plugins/bb: adapt to the new arg passing scheme, Mahmoud Mandour, 2021/07/22
- [PATCH v3 10/13] tests/plugins/insn: made arg inline not positional and parse it as bool, Mahmoud Mandour, 2021/07/22
- [PATCH v3 11/13] tests/plugins/mem: introduce "track" arg and make args not positional, Mahmoud Mandour, 2021/07/22
- [PATCH v3 12/13] tests/plugins/syscalls: adhere to new arg-passing scheme,
Mahmoud Mandour <=
- [PATCH v3 13/13] docs/deprecated: deprecate passing plugin args through `arg=`, Mahmoud Mandour, 2021/07/22
- Re: [PATCH v3 00/13] new plugin argument passing scheme, Mahmoud Mandour, 2021/07/23