[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-6.1 v6 03/17] target/alpha: Drop goto_tb path in gen_call_pal
From: |
Richard Henderson |
Subject: |
[PATCH for-6.1 v6 03/17] target/alpha: Drop goto_tb path in gen_call_pal |
Date: |
Tue, 20 Jul 2021 09:54:25 -1000 |
We are certain of a page crossing here, entering the
PALcode image, so the call to use_goto_tb that should
have been here will never succeed.
We are shortly going to add an assert to tcg_gen_goto_tb
that would trigger for this case.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/alpha/translate.c | 15 ++-------------
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/target/alpha/translate.c b/target/alpha/translate.c
index 103c6326a2..949ba6ffde 100644
--- a/target/alpha/translate.c
+++ b/target/alpha/translate.c
@@ -1207,19 +1207,8 @@ static DisasJumpType gen_call_pal(DisasContext *ctx, int
palcode)
? 0x2000 + (palcode - 0x80) * 64
: 0x1000 + palcode * 64);
- /* Since the destination is running in PALmode, we don't really
- need the page permissions check. We'll see the existence of
- the page when we create the TB, and we'll flush all TBs if
- we change the PAL base register. */
- if (!ctx->base.singlestep_enabled) {
- tcg_gen_goto_tb(0);
- tcg_gen_movi_i64(cpu_pc, entry);
- tcg_gen_exit_tb(ctx->base.tb, 0);
- return DISAS_NORETURN;
- } else {
- tcg_gen_movi_i64(cpu_pc, entry);
- return DISAS_PC_UPDATED;
- }
+ tcg_gen_movi_i64(cpu_pc, entry);
+ return DISAS_PC_UPDATED;
}
#endif
}
--
2.25.1
- [PATCH for-6.1 v6 00/17] tcg: breakpoint reorg, Richard Henderson, 2021/07/20
- [PATCH for-6.1 v6 01/17] accel/tcg: Reduce CF_COUNT_MASK to match TCG_MAX_INSNS, Richard Henderson, 2021/07/20
- [PATCH for-6.1 v6 02/17] accel/tcg: Move curr_cflags into cpu-exec.c, Richard Henderson, 2021/07/20
- [PATCH for-6.1 v6 03/17] target/alpha: Drop goto_tb path in gen_call_pal,
Richard Henderson <=
- [PATCH for-6.1 v6 05/17] accel/tcg: Drop CF_NO_GOTO_PTR from -d nochain, Richard Henderson, 2021/07/20
- [PATCH for-6.1 v6 10/17] target/i386: Implement debug_check_breakpoint, Richard Henderson, 2021/07/20
- [PATCH for-6.1 v6 04/17] accel/tcg: Add CF_NO_GOTO_TB and CF_NO_GOTO_PTR, Richard Henderson, 2021/07/20
- [PATCH for-6.1 v6 06/17] accel/tcg: Handle -singlestep in curr_cflags, Richard Henderson, 2021/07/20
- [PATCH for-6.1 v6 07/17] accel/tcg: Use CF_NO_GOTO_{TB, PTR} in cpu_exec_step_atomic, Richard Henderson, 2021/07/20
- [PATCH for-6.1 v6 08/17] hw/core: Introduce TCGCPUOps.debug_check_breakpoint, Richard Henderson, 2021/07/20
- [PATCH for-6.1 v6 09/17] target/arm: Implement debug_check_breakpoint, Richard Henderson, 2021/07/20
- [PATCH for-6.1 v6 11/17] hw/core: Introduce CPUClass.gdb_adjust_breakpoint, Richard Henderson, 2021/07/20