[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-6.1? 16/16] vl: Don't continue after -smp help.
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH-for-6.1? 16/16] vl: Don't continue after -smp help. |
Date: |
Tue, 20 Jul 2021 20:08:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 7/20/21 2:54 PM, Markus Armbruster wrote:
> We continue after -smp help:
>
> $ qemu-system-x86_64 -smp help -display none -monitor stdio
> smp-opts options:
> cores=<num>
> cpus=<num>
> dies=<num>
> maxcpus=<num>
> sockets=<num>
> threads=<num>
> QEMU 6.0.50 monitor - type 'help' for more information
> (qemu)
>
> Other options, such as -object help and -device help, don't.
>
> Adjust -smp not to continue either.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> softmmu/vl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/softmmu/vl.c b/softmmu/vl.c
> index ce0ecc736b..8f9d97635a 100644
> --- a/softmmu/vl.c
> +++ b/softmmu/vl.c
> @@ -1543,7 +1543,7 @@ machine_parse_property_opt(QemuOptsList *opts_list,
> const char *propname,
> prop = keyval_parse(arg, opts_list->implied_opt_name, &help,
> &error_fatal);
> if (help) {
> qemu_opts_print_help(opts_list, true);
> - return;
> + exit(0);
> }
> opts = qdict_new();
> qdict_put(opts, propname, prop);
>
Easy one for 6.1.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- Re: [PATCH 11/16] microvm: Drop dead error handling in microvm_machine_state_init(), (continued)
- [PATCH 04/16] multi-process: Fix pci_proxy_dev_realize() error handling, Markus Armbruster, 2021/07/20
- [PATCH 15/16] vl: Clean up -smp error handling, Markus Armbruster, 2021/07/20
- [PATCH 14/16] Remove superfluous ERRP_GUARD(), Markus Armbruster, 2021/07/20
- [PATCH 16/16] vl: Don't continue after -smp help., Markus Armbruster, 2021/07/20
- [PATCH 12/16] vhost: Clean up how VhostOpts method vhost_get_config() fails, Markus Armbruster, 2021/07/20
- [PATCH 13/16] vhost: Clean up how VhostOpts method vhost_backend_init() fails, Markus Armbruster, 2021/07/20
- [PATCH 01/16] error: Use error_fatal to simplify obvious fatal errors (again), Markus Armbruster, 2021/07/20
- Re: [PATCH 00/16] Various error handling fixes and cleanups, Michael S. Tsirkin, 2021/07/23
- Re: [PATCH 00/16] Various error handling fixes and cleanups, Markus Armbruster, 2021/07/29