[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/16] spapr: Plug memory leak when we can't add a migration
From: |
David Gibson |
Subject: |
Re: [PATCH 02/16] spapr: Plug memory leak when we can't add a migration blocker |
Date: |
Tue, 20 Jul 2021 23:12:59 +1000 |
On Tue, Jul 20, 2021 at 02:53:54PM +0200, Markus Armbruster wrote:
> Fixes: 2500fb423adb17995485de0b4d507cf2f09e3a7f
> Cc: Aravinda Prasad <arawinda.p@gmail.com>
> Cc: Ganesh Goudar <ganeshgr@linux.ibm.com>
> Cc: David Gibson <david@gibson.dropbear.id.au>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> hw/ppc/spapr_events.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c
> index 0cfc19be19..a8f2cc6bdc 100644
> --- a/hw/ppc/spapr_events.c
> +++ b/hw/ppc/spapr_events.c
> @@ -872,7 +872,6 @@ void spapr_mce_req_event(PowerPCCPU *cpu, bool recovered)
> SpaprMachineState *spapr = SPAPR_MACHINE(qdev_get_machine());
> CPUState *cs = CPU(cpu);
> int ret;
> - Error *local_err = NULL;
>
> if (spapr->fwnmi_machine_check_addr == -1) {
> /* Non-FWNMI case, deliver it like an architected CPU interrupt. */
> @@ -912,7 +911,7 @@ void spapr_mce_req_event(PowerPCCPU *cpu, bool recovered)
> }
> }
>
> - ret = migrate_add_blocker(spapr->fwnmi_migration_blocker, &local_err);
> + ret = migrate_add_blocker(spapr->fwnmi_migration_blocker, NULL);
> if (ret == -EBUSY) {
> /*
> * We don't want to abort so we let the migration to continue.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [PATCH 00/16] Various error handling fixes and cleanups, Markus Armbruster, 2021/07/20
- [PATCH 02/16] spapr: Plug memory leak when we can't add a migration blocker, Markus Armbruster, 2021/07/20
- Re: [PATCH 02/16] spapr: Plug memory leak when we can't add a migration blocker,
David Gibson <=
- [PATCH 06/16] i386: Never free migration blocker objects instead of sometimes, Markus Armbruster, 2021/07/20
- [PATCH 09/16] migration: Unify failure check for migrate_add_blocker(), Markus Armbruster, 2021/07/20
- [PATCH 10/16] migration: Handle migration_incoming_setup() errors consistently, Markus Armbruster, 2021/07/20
- [PATCH 03/16] spapr: Explain purpose of ->fwnmi_migration_blocker more clearly, Markus Armbruster, 2021/07/20
- [PATCH 08/16] whpx nvmm: Drop useless migrate_del_blocker(), Markus Armbruster, 2021/07/20