[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 0/5] hw/nvme: fix mmio read
From: |
Klaus Jensen |
Subject: |
Re: [PATCH v3 0/5] hw/nvme: fix mmio read |
Date: |
Mon, 19 Jul 2021 08:43:33 +0200 |
On Jul 14 08:01, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Fix mmio read issues on big-endian hosts. The core issue is that values
> in the BAR is not stored in little endian as required.
>
> Fix that and add a regression test for this. This required a bit of
> cleanup, so it blew up into a series.
>
> v2:
>
> * "hw/nvme: use symbolic names for registers"
> Use offsetof(NvmeBar, reg) instead of explicit offsets (Philippe)
>
> * "hw/nvme: fix mmio read"
> Use the st/ld API instead of cpu_to_X (Philippe)
>
> Klaus Jensen (5):
> hw/nvme: split pmrmsc register into upper and lower
> hw/nvme: use symbolic names for registers
> hw/nvme: fix out-of-bounds reads
> hw/nvme: fix mmio read
> tests/qtest/nvme-test: add mmio read test
>
> include/block/nvme.h | 60 +++++--
> hw/nvme/ctrl.c | 362 +++++++++++++++++++++++-----------------
> tests/qtest/nvme-test.c | 26 +++
> 3 files changed, 276 insertions(+), 172 deletions(-)
>
Oi,
A review on patch 3 and 4 would be appreciated so this has a chance of
reaching Peter for -rc0 :)
signature.asc
Description: PGP signature
[PATCH v3 3/5] hw/nvme: fix out-of-bounds reads, Klaus Jensen, 2021/07/14
[PATCH v3 4/5] hw/nvme: fix mmio read, Klaus Jensen, 2021/07/14
[PATCH v3 5/5] tests/qtest/nvme-test: add mmio read test, Klaus Jensen, 2021/07/14
Re: [PATCH v3 0/5] hw/nvme: fix mmio read,
Klaus Jensen <=