Re: [PATCH for-6.2 03/10] linux-user: Split signal-related prototypes into sighandling.h

[Philippe Mathieu-Daudé]

On 7/18/21 1:20 AM, Peter Maydell wrote:
> Split the signal related prototypes into a new header file
> sighandling.h, and include it in those places that require it.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  linux-user/qemu.h                | 36 --------------------
>  linux-user/sighandling.h         | 56 ++++++++++++++++++++++++++++++++
>  linux-user/aarch64/cpu_loop.c    |  1 +
>  linux-user/aarch64/signal.c      |  1 +
>  linux-user/alpha/cpu_loop.c      |  1 +
>  linux-user/alpha/signal.c        |  1 +
>  linux-user/arm/cpu_loop.c        |  1 +
>  linux-user/arm/signal.c          |  1 +
>  linux-user/cris/cpu_loop.c       |  1 +
>  linux-user/cris/signal.c         |  1 +
>  linux-user/fd-trans.c            |  1 +
>  linux-user/hexagon/cpu_loop.c    |  1 +
>  linux-user/hexagon/signal.c      |  1 +
>  linux-user/hppa/cpu_loop.c       |  1 +
>  linux-user/hppa/signal.c         |  1 +
>  linux-user/i386/cpu_loop.c       |  1 +
>  linux-user/i386/signal.c         |  1 +
>  linux-user/m68k/cpu_loop.c       |  1 +
>  linux-user/m68k/signal.c         |  1 +
>  linux-user/main.c                |  1 +
>  linux-user/microblaze/cpu_loop.c |  1 +
>  linux-user/microblaze/signal.c   |  1 +
>  linux-user/mips/cpu_loop.c       |  1 +
>  linux-user/mips/signal.c         |  1 +
>  linux-user/nios2/cpu_loop.c      |  1 +
>  linux-user/nios2/signal.c        |  1 +
>  linux-user/openrisc/cpu_loop.c   |  1 +
>  linux-user/openrisc/signal.c     |  1 +
>  linux-user/ppc/cpu_loop.c        |  1 +
>  linux-user/ppc/signal.c          |  1 +
>  linux-user/riscv/cpu_loop.c      |  1 +
>  linux-user/riscv/signal.c        |  1 +
>  linux-user/s390x/cpu_loop.c      |  1 +
>  linux-user/s390x/signal.c        |  1 +
>  linux-user/sh4/cpu_loop.c        |  1 +
>  linux-user/sh4/signal.c          |  1 +
>  linux-user/signal.c              |  1 +
>  linux-user/sparc/cpu_loop.c      |  1 +
>  linux-user/sparc/signal.c        |  1 +
>  linux-user/syscall.c             |  1 +
>  linux-user/xtensa/cpu_loop.c     |  1 +
>  linux-user/xtensa/signal.c       |  1 +
>  42 files changed, 96 insertions(+), 36 deletions(-)
>  create mode 100644 linux-user/sighandling.h

The difference between "signal-common.h" and "sighandling.h"
is not clear. Could they be merged? Anyway:

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>