RE: [PATCH] target/hexagon: Drop include of qemu.h

[Taylor Simpson]

> -----Original Message-----
> From: Peter Maydell <peter.maydell@linaro.org>
> Sent: Saturday, July 17, 2021 4:30 AM
> To: qemu-devel@nongnu.org
> Cc: Taylor Simpson <tsimpson@quicinc.com>
> Subject: [PATCH] target/hexagon: Drop include of qemu.h
> 
> The qemu.h file is a CONFIG_USER_ONLY header; it doesn't appear on the
> include path for softmmu builds.  Currently we include it unconditionally in
> target/hexagon/op_helper.c.  We used to need it for the put_user_*() and
> get_user_*() functions, but now that we have removed the uses of those
> from op_helper.c, the only reason it's still there is that we're implicitly 
> relying
> on it pulling in some other headers.
> 
> Explicitly include the headers we need for other functions, and drop the
> include of qemu.h.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Based-on: 1626384156-6248-1-git-send-email-tsimpson@quicinc.com
> ("[PATCH v3 0/2] SIGSEGV fixes")


Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>

Thanks Peter,
I'll add this to the series and send you a pull request.


Taylor