Re: [PATCH v2 04/10] accel/tcg: Drop CF_NO_GOTO_PTR from -d nochain

[Richard Henderson]

On 7/17/21 10:39 AM, Alex Bennée wrote:
> Richard Henderson <richard.henderson@linaro.org> writes:
>
> > The purpose of suppressing goto_ptr from -d nochain had been
> > to return to the main loop so that -d cpu would be recognized.
>
> Hmm is it though? I've always treated it as ensuring we always come out
> into the main loop (which is helpful for debugging).

What's helpful for debugging wrt the main loop beyond logging?


r~

> > But we now include -d cpu logging in helper_lookup_tb_ptr so
> > there is no need to exclude goto_ptr.
> >
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >   accel/tcg/cpu-exec.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
> > index d3232d5764..70ea3c7d68 100644
> > --- a/accel/tcg/cpu-exec.c
> > +++ b/accel/tcg/cpu-exec.c
> > @@ -150,7 +150,7 @@ uint32_t curr_cflags(CPUState *cpu)
> >       uint32_t cflags = cpu->tcg_cflags;
> >   
> >       if (qemu_loglevel_mask(CPU_LOG_TB_NOCHAIN)) {
> > -        cflags |= CF_NO_GOTO_TB | CF_NO_GOTO_PTR;
> > +        cflags |= CF_NO_GOTO_TB;
> >       }
> >   
> >       return cflags;