[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 32/40] tcg/plugins: enable by default for most TCG builds
From: |
Alex Bennée |
Subject: |
Re: [PULL 32/40] tcg/plugins: enable by default for most TCG builds |
Date: |
Fri, 16 Jul 2021 14:16:01 +0100 |
User-agent: |
mu4e 1.5.13; emacs 28.0.50 |
Christian Borntraeger <borntraeger@de.ibm.com> writes:
> On 16.07.21 08:54, Christian Borntraeger wrote:
>> On 12.07.21 14:26, Alex Bennée wrote:
>>> Aside from a minor bloat to file size the ability to have TCG plugins
>>> has no real impact on performance unless a plugin is actively loaded.
>>> Even then the libempty.so plugin shows only a minor degradation in
>>> performance caused by the extra book keeping the TCG has to do to keep
>>> track of instructions. As it's a useful feature lets just enable it by
>>> default and reduce our testing matrix a little.
>>>
>>> We need to move our linker testing earlier so we can be sure we can
>>> enable the loader module required. As we have ruled out static &
>>> plugins in an earlier patch we can also reduce the indent a little.
>>>
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>>> Message-Id: <20210709143005.1554-33-alex.bennee@linaro.org>
>> I cant reproduce it manually but in our build regression this fails
>> with
>
> I can now reproduce when adding
> --extra-ldflags="-Wl,--build-id -pie -Wl,-z,relro -Wl,-z,now"
> to the configure script (on "20.04.2 LTS)
Whats your full configure line? And this is on the s390x-cloud machine?
--
Alex Bennée
- [PULL 33/40] contrib/plugins: enable -Wall for building plugins, (continued)
- [PULL 33/40] contrib/plugins: enable -Wall for building plugins, Alex Bennée, 2021/07/12
- [PULL 35/40] docs/devel: tcg-plugins: add execlog plugin description, Alex Bennée, 2021/07/12
- [PULL 11/40] tests/docker: use project specific container registries, Alex Bennée, 2021/07/12
- [PULL 13/40] tests/docker: remove FEATURES env var from templates, Alex Bennée, 2021/07/12
- [PULL 24/40] tests/vm: update NetBSD to 9.2, Alex Bennée, 2021/07/12
- [PULL 23/40] tests/docker: expand opensuse-leap package list, Alex Bennée, 2021/07/12
- [PULL 26/40] tests/tcg: make test-mmap a little less aggressive, Alex Bennée, 2021/07/12
- [PULL 32/40] tcg/plugins: enable by default for most TCG builds, Alex Bennée, 2021/07/12
- Re: [PULL 32/40] tcg/plugins: enable by default for most TCG builds, Christian Borntraeger, 2021/07/16
- Re: [PULL 32/40] tcg/plugins: enable by default for most TCG builds, Christian Borntraeger, 2021/07/16
- Re: [PULL 32/40] tcg/plugins: enable by default for most TCG builds,
Alex Bennée <=
- Re: [PULL 32/40] tcg/plugins: enable by default for most TCG builds, Richard Henderson, 2021/07/16
- Re: [PULL 32/40] tcg/plugins: enable by default for most TCG builds, Christian Borntraeger, 2021/07/16
- Re: [PULL 32/40] tcg/plugins: enable by default for most TCG builds, Christian Borntraeger, 2021/07/16
- Re: [PULL 32/40] tcg/plugins: enable by default for most TCG builds, Richard Henderson, 2021/07/16
[PULL 34/40] contrib/plugins: add execlog to log instruction execution and memory access, Alex Bennée, 2021/07/12
[PULL 22/40] tests/docker: expand ubuntu2004 package list, Alex Bennée, 2021/07/12
[PULL 40/40] MAINTAINERS: Added myself as a reviewer for TCG Plugins, Alex Bennée, 2021/07/12
[PULL 37/40] plugins/cache: Enable cache parameterization, Alex Bennée, 2021/07/12
[PULL 20/40] tests/docker: expand fedora package list, Alex Bennée, 2021/07/12
[PULL 30/40] configure: add an explicit static and plugins check, Alex Bennée, 2021/07/12