[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 20/26] io: use GDateTime for formatting timestamp for websock head
From: |
Daniel P . Berrangé |
Subject: |
[PULL 20/26] io: use GDateTime for formatting timestamp for websock headers |
Date: |
Wed, 14 Jul 2021 15:08:52 +0100 |
The GDateTime APIs provided by GLib avoid portability pitfalls, such
as some platforms where 'struct timeval.tv_sec' field is still 'long'
instead of 'time_t'. When combined with automatic cleanup, GDateTime
often results in simpler code too.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
io/channel-websock.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/io/channel-websock.c b/io/channel-websock.c
index 03c1f7cb62..70889bb54d 100644
--- a/io/channel-websock.c
+++ b/io/channel-websock.c
@@ -177,15 +177,9 @@ qio_channel_websock_handshake_send_res(QIOChannelWebsock
*ioc,
static gchar *qio_channel_websock_date_str(void)
{
- struct tm tm;
- time_t now = time(NULL);
- char datebuf[128];
+ g_autoptr(GDateTime) now = g_date_time_new_now_utc();
- gmtime_r(&now, &tm);
-
- strftime(datebuf, sizeof(datebuf), "%a, %d %b %Y %H:%M:%S GMT", &tm);
-
- return g_strdup(datebuf);
+ return g_date_time_format(now, "%a, %d %b %Y %H:%M:%S GMT");
}
static void qio_channel_websock_handshake_send_res_err(QIOChannelWebsock *ioc,
--
2.31.1
- [PULL 10/26] crypto: delete built-in XTS cipher mode support, (continued)
- [PULL 10/26] crypto: delete built-in XTS cipher mode support, Daniel P . Berrangé, 2021/07/14
- [PULL 11/26] crypto: replace 'des-rfb' cipher with 'des', Daniel P . Berrangé, 2021/07/14
- [PULL 13/26] crypto: introduce build system for gnutls crypto backend, Daniel P . Berrangé, 2021/07/14
- [PULL 12/26] crypto: flip priority of backends to prefer gcrypt, Daniel P . Berrangé, 2021/07/14
- [PULL 14/26] crypto: add gnutls cipher provider, Daniel P . Berrangé, 2021/07/14
- [PULL 15/26] crypto: add gnutls hash provider, Daniel P . Berrangé, 2021/07/14
- [PULL 16/26] crypto: add gnutls hmac provider, Daniel P . Berrangé, 2021/07/14
- [PULL 17/26] crypto: add gnutls pbkdf provider, Daniel P . Berrangé, 2021/07/14
- [PULL 18/26] crypto: prefer gnutls as the crypto backend if new enough, Daniel P . Berrangé, 2021/07/14
- [PULL 19/26] net/rocker: use GDateTime for formatting timestamp in debug messages, Daniel P . Berrangé, 2021/07/14
- [PULL 20/26] io: use GDateTime for formatting timestamp for websock headers,
Daniel P . Berrangé <=
- [PULL 21/26] seccomp: don't block getters for resource control syscalls, Daniel P . Berrangé, 2021/07/14
- [PULL 22/26] tests/migration: fix unix socket migration, Daniel P . Berrangé, 2021/07/14
- [PULL 23/26] docs: fix typo s/Intel/AMD/ in CPU model notes, Daniel P . Berrangé, 2021/07/14
- [PULL 24/26] qemu-options: re-arrange CPU topology options, Daniel P . Berrangé, 2021/07/14
- [PULL 25/26] qemu-options: tweak to show that CPU count is optional, Daniel P . Berrangé, 2021/07/14
- [PULL 26/26] qemu-options: rewrite help for -smp options, Daniel P . Berrangé, 2021/07/14
- Re: [PULL v2 00/26] Crypto and more patches, Peter Maydell, 2021/07/15