[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RESEND v2 0/3] To add HMP interface to dump PCI MSI-X table/P
|
From: |
Dongli Zhang |
|
Subject: |
Re: [PATCH RESEND v2 0/3] To add HMP interface to dump PCI MSI-X table/PBA |
|
Date: |
Tue, 13 Jul 2021 15:30:30 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 |
On 7/13/21 1:59 PM, Michael S. Tsirkin wrote:
> On Mon, Jul 12, 2021 at 04:58:09PM -0700, Dongli Zhang wrote:
>> I have just rebased the v2 patchset on top of most recent qemu to resend.
>>
>> This patch is to introduce the new HMP command to dump the MSI-X table/PBA.
>>
>> Here is the RFC v1:
>>
>> https://urldefense.com/v3/__https://lists.gnu.org/archive/html/qemu-devel/2021-04/msg04673.html__;!!ACWV5N9M2RV99hQ!a_4RXoxWC3ppSNDk4TFH5-UjOMa9DsHfWF3x814Yf6urzW3rxZrwhWCU2zTFVDD57lE$
>>
>>
>> The idea was inspired by below discussion:
>>
>> https://urldefense.com/v3/__https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg09020.html__;!!ACWV5N9M2RV99hQ!a_4RXoxWC3ppSNDk4TFH5-UjOMa9DsHfWF3x814Yf6urzW3rxZrwhWCU2zTFAnnr09M$
>>
>
> Fails build for microblaze:
>
> /scm/qemu/build/../softmmu/qdev-monitor.c:1030: undefined reference to
> `msix_dump_info'
> collect2: error: ld returned 1 exit status
> [2525/8445] Compiling C object
> libqemu-microblaze-softmmu.fa.p/meson-generated_.._qapi_qapi-visit-misc-target.c.o
>
I am so sorry for the build error. I will add below to the hw/pci/pci-stub.c.
void msix_dump_info(Monitor *mon, PCIDevice *dev, Error **errp)
{
monitor_printf(mon, "PCI devices not supported\n");
}
I will send out v3.
I should test for all arch instead of only x86_64-softmmu in the future.
Thank you very much!
Dongli Zhang