qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] qga-win: Increase VSS freeze timeout to 60 secs instead


From: Michael Roth
Subject: Re: [PATCH 1/3] qga-win: Increase VSS freeze timeout to 60 secs instead of 10
Date: Tue, 13 Jul 2021 13:40:22 -0500
User-agent: alot/0.9

Quoting Konstantin Kostiuk (2021-04-22 02:43:25)
> ping

I've been trying to get these queued but I'm hitting an issue where qga
reports:

  failed to load qga-vss.dll: The specified module could not be found.

via LoadLibraryA(QGA_VSS_DLL) returning error code 126. What's weird is
it seems to find qga-vss.dll in the install directory, and you can see it
access it in WinDBG and various trace tools, but somehow it reports not
found. Are you seeing this issue?

I'll debug more this week and try to get these in for rc1, but if you happen
to have more of a clue than me then any insights would be much appreciated.

> 
> On Mon, Apr 5, 2021 at 4:14 PM Basil Salman <basil@daynix.com> wrote:
> 
>     Currently Requester freeze times out after 10 seconds, while
>     the default timeout for Writer Freeze is 60 seconds. according to
>     VSS Documentation [1].
>     [1]: https://docs.microsoft.com/en-us/windows/win32/vss/
>     overview-of-processing-a-backup-under-vss
> 
>     Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1909073
> 
>     Signed-off-by: Basil Salman <bsalman@daynix.com>
>     Signed-off-by: Basil Salman <basil@daynix.com>
>     ---
>      qga/vss-win32/requester.cpp | 2 +-
>      1 file changed, 1 insertion(+), 1 deletion(-)
> 
>     diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp
>     index 5378c55d23..940a2c8f55 100644
>     --- a/qga/vss-win32/requester.cpp
>     +++ b/qga/vss-win32/requester.cpp
>     @@ -18,7 +18,7 @@
>      #include <inc/win2003/vsbackup.h>
> 
>      /* Max wait time for frozen event (VSS can only hold writes for 10
>     seconds) */
>     -#define VSS_TIMEOUT_FREEZE_MSEC 10000
>     +#define VSS_TIMEOUT_FREEZE_MSEC 60000
> 
>      /* Call QueryStatus every 10 ms while waiting for frozen event */
>      #define VSS_TIMEOUT_EVENT_MSEC 10
>     --
>     2.17.2
> 
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]