[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-S
From: |
Eric Blake |
Subject: |
Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP |
Date: |
Tue, 13 Jul 2021 13:21:04 -0500 |
User-agent: |
NeoMutt/20210205-569-37ed14 |
On Fri, Jul 09, 2021 at 04:55:46PM -0500, Brijesh Singh wrote:
> To launch the SEV-SNP guest, a user can specify up to 8 parameters.
> Passing all parameters through command line can be difficult. To simplify
> the launch parameter passing, introduce a .ini-like config file that can be
> used for passing the parameters to the launch flow.
I agree with Markus' assessment that we are probably going to be
better off reusing what we already have for other complex options
rather than inventing yet another ini file.
Additional things I noted:
> +++ b/qapi/qom.json
> @@ -749,6 +749,10 @@
> # @reduced-phys-bits: number of bits in physical addresses that become
> # unavailable when SEV is enabled
> #
> +# @snp: SEV-SNP is enabled (default: 0)
Here you list 0...
> +#
> +# @launch-config: launch config file to use
Both additions (if we keep the launch-config addition) are missing
'(since 6.1)' notations.
> +#
> # Since: 2.12
> ##
> { 'struct': 'SevGuestProperties',
> @@ -758,6 +762,8 @@
> '*policy': 'uint32',
> '*handle': 'uint32',
> '*cbitpos': 'uint32',
> + '*snp': 'bool',
...but here you state snp is bool. That means the default is 'false', not '0'.
> + '*launch-config': 'str',
> 'reduced-phys-bits': 'uint32' } }
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP, (continued)
Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP, Markus Armbruster, 2021/07/13
- Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP, Brijesh Singh, 2021/07/14
- Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP, Michael Roth, 2021/07/20
- Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP, Daniel P . Berrangé, 2021/07/20
- Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP, Markus Armbruster, 2021/07/21
- Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP, Michael Roth, 2021/07/21
Re: [RFC PATCH 2/6] i386/sev: extend sev-guest property to include SEV-SNP,
Eric Blake <=
[RFC PATCH 3/6] i386/sev: initialize SNP context, Brijesh Singh, 2021/07/09
[RFC PATCH 4/6] i386/sev: add the SNP launch start context, Brijesh Singh, 2021/07/09
[RFC PATCH 5/6] i386/sev: add support to encrypt BIOS when SEV-SNP is enabled, Brijesh Singh, 2021/07/09