[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/4] Fixes for the --without-default-features configure switc
From: |
Cole Robinson |
Subject: |
Re: [PATCH 0/4] Fixes for the --without-default-features configure switch |
Date: |
Tue, 13 Jul 2021 10:54:40 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 7/13/21 5:31 AM, Thomas Huth wrote:
> Many features do not get properly disabled when the user runs the
> configure script with --without-default-features. Let's fix that now.
>
> Thomas Huth (4):
> configure: Fix --without-default-features propagation to meson
> configure: Allow vnc to get disabled with --without-default-features
> configure: Fix the default setting of the "xen" feature
> configure: Let --without-default-features disable vhost-kernel and
> vhost-vdpa
>
Patches look fine and fix some issues but others persist
(--disable-system isn't triggered). IMO this needs an audit, but more
importantly 'configure' should be rearranged a bit to make this less
likely to regress:
* move all the --enable/--disable variable init into one section with
nothing else mixed in
* convert the values to all use
$default_yes/no/auto/enabled/disabled/... variable syntax so visually
it's consistent, and if a default is ever changed like $default_no ->
$default_yes then we behave correctly (as opposed to 'no' -> 'yes').
Thanks,
Cole
- [PATCH 0/4] Fixes for the --without-default-features configure switch, Thomas Huth, 2021/07/13
- [PATCH 2/4] configure: Allow vnc to get disabled with --without-default-features, Thomas Huth, 2021/07/13
- [PATCH 3/4] configure: Fix the default setting of the "xen" feature, Thomas Huth, 2021/07/13
- [PATCH 4/4] configure: Let --without-default-features disable vhost-kernel and vhost-vdpa, Thomas Huth, 2021/07/13
- Re: [PATCH 0/4] Fixes for the --without-default-features configure switch,
Cole Robinson <=
- Re: [PATCH 0/4] Fixes for the --without-default-features configure switch, Paolo Bonzini, 2021/07/14