RE: [PATCH v3 26/40] tests/tcg: make test-mmap a little less aggressive

[Taylor Simpson]

> -----Original Message-----
> From: Alex Bennée <alex.bennee@linaro.org>
> Sent: Friday, July 9, 2021 8:30 AM
> To: qemu-devel@nongnu.org
> Cc: fam@euphon.net; berrange@redhat.com; f4bug@amsat.org;
> aurelien@aurel32.net; pbonzini@redhat.com; stefanha@redhat.com;
> crosa@redhat.com; cota@braap.org; aaron@os.amperecomputing.com;
> kuhn.chenqun@huawei.com; robhenry@microsoft.com;
> mahmoudabdalghany@outlook.com; minyihh@uci.edu;
> ma.mandourr@gmail.com; Alex Bennée <alex.bennee@linaro.org>; Taylor
> Simpson <tsimpson@quicinc.com>
> Subject: [PATCH v3 26/40] tests/tcg: make test-mmap a little less aggressive
> 
> The check_aligned_anonymous_unfixed_mmaps and
> check_aligned_anonymous_unfixed_colliding_mmaps do a lot of mmap's
> and copying of data. This is especially unfriendly to targets like hexagon
> which have quite large pages and need to do sanity checks on each memory
> access.
> 
> While we are at it clean-up the white space and style issues from the legacy
> code. As we no longer do quite so much needless memory access we can
> also remove the hexagon timeout hack.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> 
> ---
> v3
>   - style and whitespace cleanups, reduce loop even further.
>   - remove hexagon timeout hack
> ---
>  tests/tcg/multiarch/test-mmap.c   | 208 +++++++++++++++---------------
>  tests/tcg/hexagon/Makefile.target |   9 --
>  2 files changed, 104 insertions(+), 113 deletions(-)


Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>