Re: [PATCH 4/4] ppc/pegasos2: Implement some RTAS functions with VOF

[BALATON Zoltan]

On Thu, 8 Jul 2021, David Gibson wrote:
> On Sun, Jun 27, 2021 at 06:27:13PM +0200, BALATON Zoltan wrote:
> > Linux uses RTAS functions to access PCI devices so we need to provide
> > these with VOF. Implement some of the most important functions to
> > allow booting Linux with VOF. With this the board is now usable
> > without a binary ROM image and we can enable it by default as other
> > boards.
> >
> > Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>
> Applied, but...
>
> > @@ -687,6 +795,29 @@ static void *build_fdt(MachineState *machine, int 
> > *fdt_size)
> >      qemu_fdt_setprop_string(fdt, "/failsafe", "device_type", "serial");
> >      qemu_fdt_setprop_string(fdt, "/failsafe", "name", "failsafe");
> >
> > +    qemu_fdt_add_subnode(fdt, "/rtas");
> > +    qemu_fdt_setprop_cell(fdt, "/rtas", "system-reboot", 20);
> > +    qemu_fdt_setprop_cell(fdt, "/rtas", "hibernate", 19);
> > +    qemu_fdt_setprop_cell(fdt, "/rtas", "suspend", 18);
> > +    qemu_fdt_setprop_cell(fdt, "/rtas", "power-off", 17);
> > +    qemu_fdt_setprop_cell(fdt, "/rtas", "set-indicator", 11);
> > +    qemu_fdt_setprop_cell(fdt, "/rtas", "display-character", 10);
> > +    qemu_fdt_setprop_cell(fdt, "/rtas", "write-pci-config", 9);
> > +    qemu_fdt_setprop_cell(fdt, "/rtas", "read-pci-config", 8);
> > +    /* Pegasos2 firmware misspells check-exception and guests use that */
> > +    qemu_fdt_setprop_cell(fdt, "/rtas", "check-execption", 7);
> > +    qemu_fdt_setprop_cell(fdt, "/rtas", "event-scan", 6);
> > +    qemu_fdt_setprop_cell(fdt, "/rtas", "set-time-of-day", 4);
> > +    qemu_fdt_setprop_cell(fdt, "/rtas", "get-time-of-day", 3);
> > +    qemu_fdt_setprop_cell(fdt, "/rtas", "nvram-store", 2);
> > +    qemu_fdt_setprop_cell(fdt, "/rtas", "nvram-fetch", 1);
> > +    qemu_fdt_setprop_cell(fdt, "/rtas", "restart-rtas", 0);
> > +    qemu_fdt_setprop_cell(fdt, "/rtas", "rtas-error-log-max", 0);
> > +    qemu_fdt_setprop_cell(fdt, "/rtas", "rtas-event-scan-rate", 0);
> > +    qemu_fdt_setprop_cell(fdt, "/rtas", "rtas-display-device", 0);
> > +    qemu_fdt_setprop_cell(fdt, "/rtas", "rtas-size", 20);
> > +    qemu_fdt_setprop_cell(fdt, "/rtas", "rtas-version", 1);
>
> ..you really want to be using your symbolic names here as well.

Sent a v2 for this patch that you can replace this with.

Regards,
BALATON Zoltan