[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Move qemu.sasl to contrib/
From: |
Cole Robinson |
Subject: |
Re: [PATCH] Move qemu.sasl to contrib/ |
Date: |
Thu, 8 Jul 2021 16:49:24 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 7/8/21 3:18 PM, Peter Maydell wrote:
> On Thu, 8 Jul 2021 at 20:14, Daniel P. Berrangé <berrange@redhat.com> wrote:
>>
>> On Thu, Jul 08, 2021 at 02:39:57PM -0400, Cole Robinson wrote:
>>> It's not installed in any way, so seems like contrib/ material
>>
>> Not really.
>>
>> Contrib is stuff that is included on an ad-hoc basis with no
>> commitment to support and no guarantee that it is working at
>> all. Yes, there is some stuff in contrib/ that doesn't
>> belong there based on this definition, and should be moved
>> out.
>
> More generally, I would like to see us get rid of contrib/
> entirely. We should either support stuff (and have it in
> sensible places in the source tree) or kick it out.
>
qemu.sasl to ui/ dir then?
Do you think we should install qemu.sasl to /etc/sasl2/qemu.conf? Its
what Fedora/RHEL packaging does by hand for qemu. And what libvirt does
for its equivalent config file
Thanks,
Cole