[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 04/15] memory: Helpers to copy/free a MemoryRegionSection
From: |
Eduardo Habkost |
Subject: |
[PULL v2 04/15] memory: Helpers to copy/free a MemoryRegionSection |
Date: |
Thu, 8 Jul 2021 15:55:41 -0400 |
From: David Hildenbrand <david@redhat.com>
In case one wants to create a permanent copy of a MemoryRegionSections,
one needs access to flatview_ref()/flatview_unref(). Instead of exposing
these, let's just add helpers to copy/free a MemoryRegionSection and
properly adjust references.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Alex Williamson <alex.williamson@redhat.com>
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Cc: Peter Xu <peterx@redhat.com>
Cc: Auger Eric <eric.auger@redhat.com>
Cc: Wei Yang <richard.weiyang@linux.alibaba.com>
Cc: teawater <teawaterz@linux.alibaba.com>
Cc: Marek Kedzierski <mkedzier@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20210413095531.25603-3-david@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
include/exec/memory.h | 20 ++++++++++++++++++++
softmmu/memory.c | 27 +++++++++++++++++++++++++++
2 files changed, 47 insertions(+)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index 6574e46b932..27a8833173b 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -1066,6 +1066,26 @@ static inline bool
MemoryRegionSection_eq(MemoryRegionSection *a,
a->nonvolatile == b->nonvolatile;
}
+/**
+ * memory_region_section_new_copy: Copy a memory region section
+ *
+ * Allocate memory for a new copy, copy the memory region section, and
+ * properly take a reference on all relevant members.
+ *
+ * @s: the #MemoryRegionSection to copy
+ */
+MemoryRegionSection *memory_region_section_new_copy(MemoryRegionSection *s);
+
+/**
+ * memory_region_section_new_copy: Free a copied memory region section
+ *
+ * Free a copy of a memory section created via
memory_region_section_new_copy().
+ * properly dropping references on all relevant members.
+ *
+ * @s: the #MemoryRegionSection to copy
+ */
+void memory_region_section_free_copy(MemoryRegionSection *s);
+
/**
* memory_region_init: Initialize a memory region
*
diff --git a/softmmu/memory.c b/softmmu/memory.c
index d20a9dec44e..cea2f622c96 100644
--- a/softmmu/memory.c
+++ b/softmmu/memory.c
@@ -2701,6 +2701,33 @@ MemoryRegionSection memory_region_find(MemoryRegion *mr,
return ret;
}
+MemoryRegionSection *memory_region_section_new_copy(MemoryRegionSection *s)
+{
+ MemoryRegionSection *tmp = g_new(MemoryRegionSection, 1);
+
+ *tmp = *s;
+ if (tmp->mr) {
+ memory_region_ref(tmp->mr);
+ }
+ if (tmp->fv) {
+ bool ret = flatview_ref(tmp->fv);
+
+ g_assert(ret);
+ }
+ return tmp;
+}
+
+void memory_region_section_free_copy(MemoryRegionSection *s)
+{
+ if (s->fv) {
+ flatview_unref(s->fv);
+ }
+ if (s->mr) {
+ memory_region_unref(s->mr);
+ }
+ g_free(s);
+}
+
bool memory_region_present(MemoryRegion *container, hwaddr addr)
{
MemoryRegion *mr;
--
2.31.1
- [PULL v2 00/15] Machine queue, 2021-07-07, Eduardo Habkost, 2021/07/08
- [PULL v2 02/15] Deprecate pmem=on with non-DAX capable backend file, Eduardo Habkost, 2021/07/08
- [PULL v2 01/15] vmbus: Don't make QOM property registration conditional, Eduardo Habkost, 2021/07/08
- [PULL v2 03/15] memory: Introduce RamDiscardManager for RAM memory regions, Eduardo Habkost, 2021/07/08
- [PULL v2 04/15] memory: Helpers to copy/free a MemoryRegionSection,
Eduardo Habkost <=
- [PULL v2 05/15] virtio-mem: Factor out traversing unplugged ranges, Eduardo Habkost, 2021/07/08
- [PULL v2 06/15] virtio-mem: Don't report errors when ram_block_discard_range() fails, Eduardo Habkost, 2021/07/08
- [PULL v2 07/15] virtio-mem: Implement RamDiscardManager interface, Eduardo Habkost, 2021/07/08
- [PULL v2 08/15] vfio: Support for RamDiscardManager in the !vIOMMU case, Eduardo Habkost, 2021/07/08
- [PULL v2 09/15] vfio: Query and store the maximum number of possible DMA mappings, Eduardo Habkost, 2021/07/08
- [PULL v2 10/15] vfio: Sanity check maximum number of DMA mappings with RamDiscardManager, Eduardo Habkost, 2021/07/08
- [PULL v2 11/15] vfio: Support for RamDiscardManager in the vIOMMU case, Eduardo Habkost, 2021/07/08
- [PULL v2 12/15] softmmu/physmem: Don't use atomic operations in ram_block_discard_(disable|require), Eduardo Habkost, 2021/07/08
- [PULL v2 14/15] virtio-mem: Require only coordinated discards, Eduardo Habkost, 2021/07/08
- [PULL v2 13/15] softmmu/physmem: Extend ram_block_discard_(require|disable) by two discard types, Eduardo Habkost, 2021/07/08