qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Picture missing in About dialog on cocoa ui


From: Peter Maydell
Subject: Re: Picture missing in About dialog on cocoa ui
Date: Thu, 8 Jul 2021 18:50:21 +0100

On Thu, 8 Jul 2021 at 17:28, Programmingkid <programmingkidx@gmail.com> wrote:
> The problem with e31746ecf8dd2f25f687c94ac14016a3ba5debfc is it requires a
> picture file to be found in a certain path. My original code used QEMU's
> icon to obtain a picture. The reason why the picture in the About dialog
> stopped appearing was because of the move to the meson build system.
> A new patch has just been committed that fixes the missing icon issue.
> Using 'git revert e31746ecf8dd2f25f687c94ac14016a3ba5debfc' fixes the
> missing picture issue in the About dialog.

If the icon is the same (same resolution, etc) then just using it
does seem better than loading it off the filesystem. But we should
also sort out why get_relocated_path() isn't working, because if QEMU.
can't load files that way then other things will also be broken I think.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]