[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 8/8] linux-user/syscall: Remove ERRNO_TABLE_SIZE check
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v3 8/8] linux-user/syscall: Remove ERRNO_TABLE_SIZE check |
Date: |
Thu, 8 Jul 2021 19:34:09 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
Le 08/07/2021 à 19:05, Philippe Mathieu-Daudé a écrit :
> Now than target_to_host_errno() always return an errno, we can
> remove the unused and arbitrary ERRNO_TABLE_SIZE definition.
>
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> linux-user/syscall.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 94ec6f730b3..376629c6891 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -507,8 +507,6 @@ static inline int next_free_host_timer(void)
> }
> #endif
>
> -#define ERRNO_TABLE_SIZE 1200
> -
> static inline int host_to_target_errno(int host_errno)
> {
> switch (host_errno) {
> @@ -548,9 +546,6 @@ const char *target_strerror(int err)
> return "Successful exit from sigreturn";
> }
>
> - if ((err >= ERRNO_TABLE_SIZE) || (err < 0)) {
> - return NULL;
> - }
> return strerror(target_to_host_errno(err));
> }
>
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
- [PATCH v3 2/8] linux-user/sparc: Rename target_errno.h -> target_errno_defs.h, (continued)
- [PATCH v3 2/8] linux-user/sparc: Rename target_errno.h -> target_errno_defs.h, Philippe Mathieu-Daudé, 2021/07/08
- [PATCH v3 3/8] linux-user: Extract target errno to 'target_errno_defs.h', Philippe Mathieu-Daudé, 2021/07/08
- [PATCH v3 4/8] linux-user/alpha: Move errno definitions to 'target_errno_defs.h', Philippe Mathieu-Daudé, 2021/07/08
- [PATCH v3 5/8] linux-user/hppa: Move errno definitions to 'target_errno_defs.h', Philippe Mathieu-Daudé, 2021/07/08
- [PATCH v3 6/8] linux-user/mips: Move errno definitions to 'target_errno_defs.h', Philippe Mathieu-Daudé, 2021/07/08
- [PATCH v3 7/8] linux-user: Simplify host <-> target errno conversion using macros, Philippe Mathieu-Daudé, 2021/07/08
- [PATCH v3 8/8] linux-user/syscall: Remove ERRNO_TABLE_SIZE check, Philippe Mathieu-Daudé, 2021/07/08
- Re: [PATCH v3 0/8] linux-user: target <-> host errno conversion code refactor, Laurent Vivier, 2021/07/12