|
From: | Paolo Bonzini |
Subject: | Re: [PATCH] qemu-config: never call the callback after an error, fix leak |
Date: | Thu, 8 Jul 2021 13:40:35 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 08/07/21 11:24, Markus Armbruster wrote:
Looks like the patch fixes two separate issues: 1. Memory leak on ferror() Fixes: f7544edcd32e602af1aae86714dc7c32350d5d7c 2. Callback can run on error. Fixes: 37701411397c7b7d709ae92abd347cc593940ee5 I*think* this happens when the cb() further up fails, and when a line following the [...] section header cannot be parsed. Worth fixing the separate bugs in separate patches?
Yes, good idea. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |