Re: [PATCH] block/rbd: fix type of task->complete

[Kevin Wolf]

Am 07.07.2021 um 23:51 hat Connor Kuehl geschrieben:
> On 7/7/21 11:04 AM, Peter Lieven wrote:
> > task->complete is a bool not an integer.
> > 
> > Signed-off-by: Peter Lieven <pl@kamp.de>
> > ---
> >  block/rbd.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/block/rbd.c b/block/rbd.c
> > index 01a7b94d62..dcf82b15b8 100644
> > --- a/block/rbd.c
> > +++ b/block/rbd.c
> > @@ -1066,7 +1066,7 @@ static int qemu_rbd_resize(BlockDriverState *bs, 
> > uint64_t size)
> >  static void qemu_rbd_finish_bh(void *opaque)
> >  {
> >      RBDTask *task = opaque;
> > -    task->complete = 1;
> > +    task->complete = true;
> >      aio_co_wake(task->co);
> >  }
> >  
> > 
> 
> Hi Peter,
> 
> What tree/QEMU git sha does this apply to? I am having trouble
> finding definitions for RBDTask and qemu_rbd_finish_bh; and the
> patch won't apply to my few-minutes-old clone of upstream.

It is on top of:

[PATCH v5 0/6] block/rbd: migrate to coroutines and add write zeroes support
Message-Id: <20210702172356.11574-1-idryomov@gmail.com>

Also, thanks, applied to the block branch.

Kevin