qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 30/39] configure: stop user enabling plugins on Windows fo


From: Thomas Huth
Subject: Re: [PATCH v1 30/39] configure: stop user enabling plugins on Windows for now
Date: Wed, 7 Jul 2021 06:24:03 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 06/07/2021 16.58, Alex Bennée wrote:
There are some patches on the list that enable plugins on Windows but
they still need some changes to be ready:

   https://patchew.org/QEMU/20201013002806.1447-1-luoyonggang@gmail.com/

In the meantime lets stop the user from being able to configure the
support so they don't get confused by the weird linker error messages
later.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Yonggang Luo <luoyonggang@gmail.com>
---
  configure | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/configure b/configure
index 44a487e090..9d72b31a9f 100755
--- a/configure
+++ b/configure
@@ -707,6 +707,11 @@ MINGW32*)
    else
      audio_drv_list=""
    fi
+  if "$plugins" = "yes"; then
+      error_exit "TCG plugins not currently supported on Windows platforms"
+  else
+      plugins="no"
+  fi
    supported_os="yes"
    pie="no"
  ;;

This also looks like the wrong spot for testing - the "--enable-plugins" handling is around line 1510 in the configure script, but your check has been added in line 707 already. Again, this has to be checked after the options have been parsed.

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]