qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 08/11] hw/arm/virt: Make PL061 GPIO lines pulled low, not hig


From: Richard Henderson
Subject: Re: [PATCH 08/11] hw/arm/virt: Make PL061 GPIO lines pulled low, not high
Date: Tue, 6 Jul 2021 18:32:02 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 7/2/21 3:40 AM, Peter Maydell wrote:
For the virt board we have two PL061 devices -- one for NonSecure which
is inputs only, and one for Secure which is outputs only. For the former,
we don't care whether its outputs are pulled low or high when the line is
configured as an input, because we don't connect them. For the latter,
we do care, because we wire the lines up to the gpio-pwr device, which
assumes that level 1 means "do the action" and 1 means "do nothing".
For consistency in case we add more outputs in future, configure both
PL061s to pull GPIO lines down to 0.

Reported-by: Maxim Uvarov<maxim.uvarov@linaro.org>
Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
---
  hw/arm/virt.c | 3 +++
  1 file changed, 3 insertions(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]