Re: [PATCH] tests/acceptance: Test NetBSD 5.1 on the Jazz Magnum machine

[Finn Thain]

On Mon, 5 Jul 2021, Philippe Mathieu-Daudé wrote:

> On 7/5/21 2:58 AM, Finn Thain wrote:
> > On Mon, 5 Jul 2021, Philippe Mathieu-Daudé wrote:
> > 
> >> Test NetBSD 5.1 on the Jazz Magnum machine. As the firmware is not
> >> redistributable, it has to be extracted from the floppy configuration
> >> disk coming with a Mips Magnum 4000 system, then the NTPROM_BIN_PATH
> >> environment variable has to be set. For convenience a NVRAM pre-
> >> initialized to boot NetBSD is included. The test can be run as:
> >>
> >>   $ NTPROM_BIN_PATH=/path/to/ntprom.bin \
> >>     avocado --show=app,console \
> >>     run -t machine:magnum tests/acceptance/
> >>   Fetching asset from 
> >> tests/acceptance/machine_mips_jazz.py:MipsJazz.test_magnum_netbsd_5_1
> >>    (1/1) 
> >> tests/acceptance/machine_mips_jazz.py:MipsJazz.test_magnum_netbsd_5_1:
> >>   console: EISA Bus 0 Initialization In Progress... Direct Memory Access 
> >> (DMA) System Control Port B Timer 1 OK.
> >>   console: ARC Multiboot Version 174 (SGI Version 2.6)
> >>   console: Copyright (c) 1991,1992  Microsoft Corporation
> >>   console: Actions:
> >>   console: Start Windows NT
> >>   console: Run a program
> >>   console: Run setup
> >>   console: Use the arrow keys to select.
> >>   console: Press Enter to choose.
> >>   console: Program to run:
> >>   console: scsi(0)cdrom(2)fdisk(0)boot scsi(0)cdrom(2)fdisk(0)netbsd
> >>   console: NetBSD/arc Bootstrap, Revision 1.1
> >>   console: (builds@b7.netbsd.org, Sat Nov  6 14:06:36 UTC 2010)
> >>   console: devopen: scsi(0)cdrom(2)fdisk(0) type disk file netbsd
> >>   console: NetBSD 5.1 (RAMDISK) #0: Sat Nov  6 14:17:36 UTC 2010
> >>   console: 
> >> builds@b7.netbsd.org:/home/builds/ab/netbsd-5-1-RELEASE/arc/201011061943Z-obj/home/builds/ab/netbsd-5-1-RELEASE/src/sys/arch/arc/compile/RAMDISK
> >>   console: MIPS Magnum
> 
> >> +class MipsJazz(Test):
> >> +
> >> +    timeout = 60
> >> +
> >> +    @skipUnless(os.getenv('NTPROM_BIN_PATH'), 'NTPROM_BIN_PATH not 
> >> available')
> >> +    def test_magnum_netbsd_5_1(self):
> >> +        """
> >> +        :avocado: tags=arch:mips64el
> >> +        :avocado: tags=machine:magnum
> >> +        :avocado: tags=os:netbsd
> >> +        :avocado: tags=device:sonic
> >> +        :avocado: tags=device:esp
> >> +        """
> >> +        drive_url = ('http://archive.netbsd.org/pub/NetBSD-archive/'
> >> +                     'NetBSD-5.1/iso/arccd-5.1.iso')
> > 
> > This can be updated to NetBSD 9.2 (the regressions in NetBSD have been 
> > fixed).
> 
> Indeed, with this change:
> 
> -- >8 --
> diff --git a/tests/acceptance/machine_mips_jazz.py
> b/tests/acceptance/machine_mips_jazz.py
> index 0b6640edc12..54968959372 100644
> --- a/tests/acceptance/machine_mips_jazz.py
> +++ b/tests/acceptance/machine_mips_jazz.py
> @@ -33,13 +33,11 @@ def test_magnum_netbsd_5_1(self):
>          :avocado: tags=device:sonic
>          :avocado: tags=device:esp
>          """
> -        drive_url = ('http://archive.netbsd.org/pub/NetBSD-archive/'
> -                     'NetBSD-5.1/iso/arccd-5.1.iso')
> -        drive_hash = ('c91a57fb373636247d1f1ce283a610ba529e208604a'
> -                      'f2a9e0237551fb3d25459c7697775af8c8d35a9764e'
> -                      'fca87cfb591f363643e93417cfdb8857215ceb405e')
> +        drive_url = ('http://cdn.netbsd.org/pub/NetBSD/'
> +                     'NetBSD-9.2/images/NetBSD-9.2-arc.iso')
> +        drive_hash = '409c61aee5459e762cdb120d2591ed2e'
>          drive_path = self.fetch_asset(drive_url, asset_hash=drive_hash,
> -                                      algorithm='sha512')
> +                                      algorithm='md5')
>          ntprom_hash = '316de17820192c89b8ee6d9936ab8364a739ca53'
>          ntprom_path = self.fetch_asset('file://' +
> os.getenv('NTPROM_BIN_PATH'),
>                                         asset_hash=ntprom_hash,
> algorithm='sha1')
> ---
> 
> I get:
> 
> console: [   1.0000000] NetBSD 9.2 (RAMDISK) #0: Wed May 12 13:15:55 UTC
> 2021
> console: [   1.0000000]
> mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/arc/compile/RAMDISK
> console: [   1.0000000] MIPS Magnum
> ...
> console: # [   6.1232105]
> pmap_tlb_update_addr(0x87eb5f60,0x69a000,0x1ee59e, 0)
> ...
> console: [  20.2174752] rebooting...
> PASS (48.98 s)
> 
> >> +        nvram_path = 'nvram.bin'
> > 
> > Does the test work when nvram.bin is uninitialized by the ARC firmware?
> 
> No, because the serial is not used by default.
> 
> > Perhaps the default MAC address (from the SONIC PROM) would be more 
> > appropriate? Alternatively, if you want to check that '00:00:00:02:03:04' 
> > actually got used, you can do this:
> > 
> > erase ^H, werase ^W, kill ^U, intr ^C, status ^T
> > Terminal type? [vt100] 
> > Erase is backspace.                                                     
> > (I)nstall, (S)hell or (H)alt ? s
> > # ifconfig
> > sn0: flags=0x8802<BROADCAST,SIMPLEX,MULTICAST> mtu 1500
> >         ec_capabilities=1<VLAN_MTU>
> >         ec_enabled=0
> >         address: 00:00:00:02:03:04
> > lo0: flags=0x8048<LOOPBACK,RUNNING,MULTICAST> mtu 33160
> > # 
> 
> I noticed it was not working, maybe I'm missing one of Mark's patches.
> 

That's strange. The MAC address is correct on mainline (as at 711c0418c8, 
at least) for NetBSD and Linux guests hosted on my x86 machine.

> Thanks for the review,
> 
> Phil.
>