[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 21/36] linux-user/x86_64: Raise SIGSEGV if SA_RESTORER not set
From: |
Richard Henderson |
Subject: |
[PATCH v2 21/36] linux-user/x86_64: Raise SIGSEGV if SA_RESTORER not set |
Date: |
Tue, 6 Jul 2021 16:49:17 -0700 |
This has been a fixme for some time. The effect of
returning -EFAULT from the kernel code is to raise SIGSEGV.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/i386/signal.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/linux-user/i386/signal.c b/linux-user/i386/signal.c
index 8701774e37..9894e7c9ac 100644
--- a/linux-user/i386/signal.c
+++ b/linux-user/i386/signal.c
@@ -411,10 +411,13 @@ void setup_rt_frame(int sig, struct target_sigaction *ka,
/* Set up to return from userspace. If provided, use a stub
already in userspace. */
-#ifndef TARGET_X86_64
if (ka->sa_flags & TARGET_SA_RESTORER) {
__put_user(ka->sa_restorer, &frame->pretcode);
} else {
+#ifdef TARGET_X86_64
+ /* For x86_64, SA_RESTORER is required ABI. */
+ goto give_sigsegv;
+#else
uint16_t val16;
addr = frame_addr + offsetof(struct rt_sigframe, retcode);
__put_user(addr, &frame->pretcode);
@@ -423,12 +426,8 @@ void setup_rt_frame(int sig, struct target_sigaction *ka,
__put_user(TARGET_NR_rt_sigreturn, (int *)(frame->retcode+1));
val16 = 0x80cd;
__put_user(val16, (uint16_t *)(frame->retcode+5));
- }
-#else
- /* XXX: Would be slightly better to return -EFAULT here if test fails
- assert(ka->sa_flags & TARGET_SA_RESTORER); */
- __put_user(ka->sa_restorer, &frame->pretcode);
#endif
+ }
/* Set up registers for signal handler */
env->regs[R_ESP] = frame_addr;
--
2.25.1
- [PATCH v2 14/36] linux-user/arm: Drop "_v2" from symbols in signal.c, (continued)
- [PATCH v2 14/36] linux-user/arm: Drop "_v2" from symbols in signal.c, Richard Henderson, 2021/07/06
- [PATCH v2 12/36] linux-user/aarch64: Add vdso and use it for rt_sigreturn, Richard Henderson, 2021/07/06
- [PATCH v2 15/36] target/arm: Add isar_feature_aa32_a32, Richard Henderson, 2021/07/06
- [PATCH v2 17/36] linux-user/alpha: Implement setup_sigtramp, Richard Henderson, 2021/07/06
- [PATCH v2 18/36] linux-user/cris: Implement setup_sigtramp, Richard Henderson, 2021/07/06
- [PATCH v2 16/36] linux-user/arm: Add vdso and use it for rt_sigreturn, Richard Henderson, 2021/07/06
- [PATCH v2 19/36] linux-user/hexagon: Implement setup_sigtramp, Richard Henderson, 2021/07/06
- [PATCH v2 20/36] linux-user/hppa: Add vdso and use it for rt_sigreturn, Richard Henderson, 2021/07/06
- [PATCH v2 21/36] linux-user/x86_64: Raise SIGSEGV if SA_RESTORER not set,
Richard Henderson <=
- [PATCH v2 23/36] linux-user/x86_64: Add vdso, Richard Henderson, 2021/07/06
- [PATCH v2 22/36] linux-user/i386: Add vdso and use it for sigreturn, Richard Henderson, 2021/07/06
- [PATCH v2 28/36] linux-user/nios2: Document non-use of setup_sigtramp, Richard Henderson, 2021/07/06
- [PATCH v2 25/36] linux-user/microblaze: Implement setup_sigtramp, Richard Henderson, 2021/07/06
- [PATCH v2 29/36] linux-user/openrisc: Implement setup_sigtramp, Richard Henderson, 2021/07/06
- [PATCH v2 27/36] linux-user/mips: Implement setup_sigtramp, Richard Henderson, 2021/07/06
- [PATCH v2 26/36] linux-user/mips: Tidy install_sigtramp, Richard Henderson, 2021/07/06
- [PATCH v2 24/36] linux-user/m68k: Implement setup_sigtramp, Richard Henderson, 2021/07/06
- [PATCH v2 30/36] target/ppc: Simplify encode_trampoline, Richard Henderson, 2021/07/06