RE: [PATCH 12/12] linux-user: Extract target errno related functions to 'target_errno.h'

[Taylor Simpson]

> -----Original Message-----
> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> On
> Behalf Of Philippe Mathieu-Daudé
> Sent: Sunday, July 4, 2021 12:38 PM
> To: qemu-devel@nongnu.org
> Cc: Richard Henderson <richard.henderson@linaro.org>; Jiaxun Yang
> <jiaxun.yang@flygoat.com>; Laurent Vivier <laurent@vivier.eu>; Aleksandar
> Rikalo <aleksandar.rikalo@syrmia.com>; Taylor Simpson
> <tsimpson@quicinc.com>; Philippe Mathieu-Daudé <f4bug@amsat.org>;
> Aurelien Jarno <aurelien@aurel32.net>; Helge Deller <deller@gmx.de>
> Subject: [PATCH 12/12] linux-user: Extract target errno related functions to
> 'target_errno.h'
> 
> diff --git a/linux-user/target_errno.h b/linux-user/target_errno.h new file
> mode 100644 index 00000000000..4e5e9d384c9
> --- /dev/null
> +++ b/linux-user/target_errno.h
> @@ -0,0 +1,32 @@
> +
> +void target_to_host_errno_table_init(void);

This is added as static in linux-user/syscall.c in patch 10/12.  But then, 
removed from syscall.c in this patch and added to linux-user/target_errno.c in 
this patch.

Is this so that each patch in the series will build?

> diff --git a/linux-user/target_errno.c b/linux-user/target_errno.c new file
> mode 100644 index 00000000000..2a7320d240f
> --- /dev/null
> +++ b/linux-user/target_errno.c
> @@ -0,0 +1,183 @@
> +/*
> + *  Linux syscalls

Copy/paste error?

Could you add a more descriptive comment to this file for posterity?
- How does the default behavior get inherited by targets?
- How does a target override the default behavior?
- A pointer to a target that is overriding the default behavior?


Thanks,
Taylor