[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] hw/sd: When card is in wrong state, log which state it i
From: |
Alexander Bulekov |
Subject: |
Re: [PATCH 1/3] hw/sd: When card is in wrong state, log which state it is |
Date: |
Fri, 2 Jul 2021 14:06:00 -0400 |
On 210702 1758, Philippe Mathieu-Daudé wrote:
> We report the card is in an inconsistent state, but don't precise
> in which state it is. Add this information, as it is useful when
> debugging problems.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> Message-Id: <20210624142209.1193073-2-f4bug@amsat.org>
Reviewed-by: Alexander Bulekov <alxndr@bu.edu>
> ---
> hw/sd/sd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index 282d39a7042..d8fdf84f4db 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -1504,7 +1504,8 @@ static sd_rsp_type_t sd_normal_command(SDState *sd,
> SDRequest req)
> return sd_illegal;
> }
>
> - qemu_log_mask(LOG_GUEST_ERROR, "SD: CMD%i in a wrong state\n", req.cmd);
> + qemu_log_mask(LOG_GUEST_ERROR, "SD: CMD%i in a wrong state: %s\n",
> + req.cmd, sd_state_name(sd->state));
> return sd_illegal;
> }
>
> --
> 2.31.1
>
- [PATCH 0/3] hw/sd: Check for valid address range in SEND_WRITE_PROT (CMD30), Philippe Mathieu-Daudé, 2021/07/02
- [PATCH 1/3] hw/sd: When card is in wrong state, log which state it is, Philippe Mathieu-Daudé, 2021/07/02
- Re: [PATCH 1/3] hw/sd: When card is in wrong state, log which state it is,
Alexander Bulekov <=
- [PATCH 2/3] hw/sd: Extract address_in_range() helper, log invalid accesses, Philippe Mathieu-Daudé, 2021/07/02
- [PATCH 3/3] hw/sd: Check for valid address range in SEND_WRITE_PROT (CMD30), Philippe Mathieu-Daudé, 2021/07/02
- Re: [PATCH 0/3] hw/sd: Check for valid address range in SEND_WRITE_PROT (CMD30), Philippe Mathieu-Daudé, 2021/07/05