[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] replay: improve determinism of virtio-net
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] replay: improve determinism of virtio-net |
|
Date: |
Fri, 2 Jul 2021 17:22:01 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 |
On 5/17/21 3:04 PM, Pavel Dovgalyuk wrote:
> virtio-net device uses bottom halves for callbacks.
> These callbacks should be deterministic, because they affect VM state.
> This patch replaces BH invocations with corresponding replay functions,
> making them deterministic in record/replay mode.
^ This is one change which I'm OK to give a R-b tag.
> This patch also disables guest announce timers for record/replay,
> because they break correct loadvm in deterministic mode.
^ This is another change, can you keep it separately? This
would help in case something need to be reverted.
> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
> ---
> hw/net/virtio-net.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)