Re: [PATCH v2 0/2] g364fb: fix migration (or: fix migration for MIPS magnum machines)

[Philippe Mathieu-Daudé]

On 6/25/21 6:35 PM, Mark Cave-Ayland wrote:
> I noticed whilst testing the previous dp8393x patchset that I would always
> get a segfault whilst attempting to migrate the MIPS magnum machine.
> 
> A bit of detective work shows that the problem is an incorrect 
> VMStateDescription
> in the g364fb device which expects a G364State but instead receives a
> G364SysBusState.
> 
> Looking back through the git history suggests that migration for this device
> (and also the MIPS magnum machines) has been broken for several years, so 
> patch
> 1 takes the opportunity to improve the migration stream for the framebuffer
> first whilst patch 2 contains the actual fix.
> 
> Note that I don't use the MIPS magnum machines on a regular basis but the
> patchset fixes the migration error and survives some light testing here.

> Mark Cave-Ayland (2):
>   g364fb: use RAM memory region for framebuffer
>   g364fb: add VMStateDescription for G364SysBusState
> 
>  hw/display/g364fb.c | 32 ++++++++++++++++++++------------
>  1 file changed, 20 insertions(+), 12 deletions(-)

Thanks, queued to mips-next.