[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 12/17] accel/tcg: Use CF_NO_GOTO_{TB, PTR} in cpu_exec_step_atomi
From: |
Richard Henderson |
Subject: |
[PATCH 12/17] accel/tcg: Use CF_NO_GOTO_{TB, PTR} in cpu_exec_step_atomic |
Date: |
Thu, 1 Jul 2021 08:25:32 -0700 |
Request that the one TB returns immediately, so that
we release the exclusive lock as soon as possible.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
accel/tcg/cpu-exec.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
index 2206c463f5..5bb099174f 100644
--- a/accel/tcg/cpu-exec.c
+++ b/accel/tcg/cpu-exec.c
@@ -330,8 +330,7 @@ void cpu_exec_step_atomic(CPUState *cpu)
CPUArchState *env = (CPUArchState *)cpu->env_ptr;
TranslationBlock *tb;
target_ulong cs_base, pc;
- uint32_t flags;
- uint32_t cflags = (curr_cflags(cpu) & ~CF_PARALLEL) | 1;
+ uint32_t flags, cflags;
int tb_exit;
if (sigsetjmp(cpu->jmp_env, 0) == 0) {
@@ -341,8 +340,14 @@ void cpu_exec_step_atomic(CPUState *cpu)
cpu->running = true;
cpu_get_tb_cpu_state(env, &pc, &cs_base, &flags);
- tb = tb_lookup(cpu, pc, cs_base, flags, cflags);
+ cflags = curr_cflags(cpu);
+ /* Execute in a serial context. */
+ cflags &= ~CF_PARALLEL;
+ /* After 1 insn, return and release the exclusive lock. */
+ cflags |= CF_NO_GOTO_TB | CF_NO_GOTO_PTR | 1;
+
+ tb = tb_lookup(cpu, pc, cs_base, flags, cflags);
if (tb == NULL) {
mmap_lock();
tb = tb_gen_code(cpu, pc, cs_base, flags, cflags);
--
2.25.1
- Re: [PATCH 06/17] tcg: Remove TCG_TARGET_HAS_goto_ptr, (continued)
- [PATCH 01/17] target/i386: Use cpu_breakpoint_test in breakpoint_handler, Richard Henderson, 2021/07/01
- [PATCH 07/17] accel/tcg: Reduce CF_COUNT_MASK to match TCG_MAX_INSNS, Richard Henderson, 2021/07/01
- [PATCH 05/17] accel/tcg: Log tb->cflags with -d exec, Richard Henderson, 2021/07/01
- [PATCH 04/17] accel/tcg: Split out log_cpu_exec, Richard Henderson, 2021/07/01
- [PATCH 03/17] accel/tcg: Move tb_lookup to cpu-exec.c, Richard Henderson, 2021/07/01
- [PATCH 13/17] accel/tcg: Move cflags lookup into tb_find, Richard Henderson, 2021/07/01
- [PATCH 11/17] accel/tcg: Handle -singlestep in curr_cflags, Richard Henderson, 2021/07/01
- [PATCH 12/17] accel/tcg: Use CF_NO_GOTO_{TB, PTR} in cpu_exec_step_atomic,
Richard Henderson <=
- [PATCH 17/17] cpu: Add breakpoint tracepoints, Richard Henderson, 2021/07/01
- [PATCH 09/17] accel/tcg: Add CF_NO_GOTO_TB and CF_NO_GOTO_PTR, Richard Henderson, 2021/07/01
- [PATCH 10/17] accel/tcg: Drop CF_NO_GOTO_PTR from -d nochain, Richard Henderson, 2021/07/01
- [PATCH 15/17] accel/tcg: Hoist tb_cflags to a local in translator_loop, Richard Henderson, 2021/07/01
- [PATCH 14/17] accel/tcg: Adjust interface of TranslatorOps.breakpoint_check, Richard Henderson, 2021/07/01
- [PATCH 08/17] accel/tcg: Move curr_cflags into cpu-exec.c, Richard Henderson, 2021/07/01
- [PATCH 16/17] accel/tcg: Encode breakpoint info into tb->cflags, Richard Henderson, 2021/07/01
- Re: [PATCH 00/17] tcg: breakpoint reorg, Mark Cave-Ayland, 2021/07/03