[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 14/15] python: remove auto-generated pyproject.toml file
From: |
John Snow |
Subject: |
[PULL 14/15] python: remove auto-generated pyproject.toml file |
Date: |
Wed, 30 Jun 2021 22:09:20 -0400 |
For reasons that at-present escape me, pipenv insists on creating a stub
pyproject.toml file. This file is a nuisance, because its mere presence
changes the behavior of various tools.
For instance, this stub file will cause "pip install --user -e ." to
fail in spectacular fashion with misleading errors. "pip install -e ."
works okay, but for some reason pip does not support editable installs
to the user directory when using PEP517.
References:
https://github.com/pypa/pip/pull/9990
https://github.com/pypa/pip/issues/7953
As outlined in ea1213b7ccc, it is still too early for us to consider
moving to a PEP-517 exclusive package. We must support older
distributions, so squash the annoyance for now. (Python 3.6 shipped Dec
2016, PEP517 support showed up in pip sometime in 2019 or so.)
Add 'pyproject.toml' to the 'make clean' target, and also delete it
after every pipenv invocation issued by the Makefile.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Message-id: 20210629214323.1329806-15-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
---
python/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/python/Makefile b/python/Makefile
index 0432ee0022..ac46ae33e7 100644
--- a/python/Makefile
+++ b/python/Makefile
@@ -49,6 +49,7 @@ help:
pipenv: .venv
.venv: Pipfile.lock
@PIPENV_VENV_IN_PROJECT=1 pipenv sync --dev --keep-outdated
+ rm -f pyproject.toml
@touch .venv
.PHONY: check-pipenv
@@ -91,6 +92,7 @@ check-tox:
.PHONY: clean
clean:
python3 setup.py clean --all
+ rm -f pyproject.toml
.PHONY: distclean
distclean: clean
--
2.31.1
- [PULL 05/15] python: README.rst touchups, (continued)
- [PULL 05/15] python: README.rst touchups, John Snow, 2021/06/30
- [PULL 08/15] python: update help text for check-tox, John Snow, 2021/06/30
- [PULL 04/15] python: Re-lock pipenv at *oldest* supported versions, John Snow, 2021/06/30
- [PULL 06/15] python: Add no-install usage instructions, John Snow, 2021/06/30
- [PULL 07/15] python: rename 'venv-check' target to 'check-pipenv', John Snow, 2021/06/30
- [PULL 09/15] python: Fix .PHONY Make specifiers, John Snow, 2021/06/30
- [PULL 12/15] python: Update help text on 'make check', 'make develop', John Snow, 2021/06/30
- [PULL 11/15] python: add 'make check-dev' invocation, John Snow, 2021/06/30
- [PULL 13/15] python: Update help text on 'make clean', 'make distclean', John Snow, 2021/06/30
- [PULL 10/15] python: only check qemu/ subdir with flake8, John Snow, 2021/06/30
- [PULL 14/15] python: remove auto-generated pyproject.toml file,
John Snow <=
- [PULL 15/15] python: Fix broken ReST docstrings, John Snow, 2021/06/30