[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] python: Configure tox to skip missing interpreters
From: |
Willian Rampazzo |
Subject: |
Re: [PATCH] python: Configure tox to skip missing interpreters |
Date: |
Wed, 30 Jun 2021 17:59:45 -0300 |
On Wed, Jun 30, 2021 at 3:46 PM Wainer dos Santos Moschetta
<wainersm@redhat.com> wrote:
>
> Currently tox tests against the installed interpreters, however if any
> supported interpreter is absent then it will return fail. It seems not
> reasonable to expect developers to have all supported interpreters
> installed on their systems. Luckily tox can be configured to skip
> missing interpreters.
>
> This changed the tox setup so that missing interpreters are skipped by
> default. On the CI, however, we still want to enforce it tests
> against all supported. This way on CI the
> --skip-missing-interpreters=false option is passed to tox.
>
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> ---
> Tested locally with `make check-tox` and where I only Python 3.6 and 3.9
> installed.
> Tested on CI: https://gitlab.com/wainersm/qemu/-/jobs/1390010988
> Still on CI, but I deliberately removed Python 3.8:
> https://gitlab.com/wainersm/qemu/-/jobs/1390046531
>
> .gitlab-ci.d/static_checks.yml | 1 +
> python/Makefile | 5 ++++-
> python/setup.cfg | 1 +
> 3 files changed, 6 insertions(+), 1 deletion(-)
>
Seems reasonable.
Reviewed-by: Willian Rampazzo <willianr@redhat.com>