Re: [PATCH v3 11/15] python: add 'make check-dev' invocation

[Willian Rampazzo]

On Wed, Jun 30, 2021 at 11:58 AM John Snow <jsnow@redhat.com> wrote:
>
>
>
> On Wed, Jun 30, 2021 at 10:41 AM Willian Rampazzo <wrampazz@redhat.com> wrote:
>>
>> On Tue, Jun 29, 2021 at 6:43 PM John Snow <jsnow@redhat.com> wrote:
>> >
>> > This is a *third* way to run the Python tests. Unlike the first two
>> > (check-pipenv, check-tox), this version does not require any specific
>> > interpreter version -- making it a lot easier to tell people to run it
>> > as a quick smoketest prior to submission to GitLab CI.
>> >
>> > Summary:
>> >
>> >   Checked via GitLab CI:
>> >     - check-pipenv: tests our oldest python & dependencies
>> >     - check-tox: tests newest dependencies on all non-EOL python versions
>> >   Executed only incidentally:
>> >     - check-dev: tests newest dependencies on whichever python version
>> >
>> > ('make check' does not set up any environment at all, it just runs the
>> > tests in your current environment. All four invocations perform the
>> > exact same tests, just in different execution environments.)
>> >
>> > Signed-off-by: John Snow <jsnow@redhat.com>
>> > ---
>> >  python/Makefile | 35 +++++++++++++++++++++++++++++++++--
>> >  1 file changed, 33 insertions(+), 2 deletions(-)
>> >
>>
>> Reviewed-by: Willian Rampazzo <willianr@redhat.com>
>>
>
> Thanks. I am squashing in a hotfix here to add .dev-venv to .gitignore, too. 
> Not worth an entire respin for that.
> (Assuming that's gonna be A-OK with both of you.)
>

Acked-by: Willian Rampazzo <willianr@redhat.com>