qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL


From: Richard Henderson
Subject: Re: [PATCH v2] target/s390x: Fix CC set by CONVERT TO FIXED/LOGICAL
Date: Wed, 30 Jun 2021 06:32:42 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0

On 6/30/21 3:49 AM, Ulrich Weigand wrote:
I'm thinking that should be able to remove TCGv_i32 cc_op in the
translator and manually write back to the slot instead.  We already
do a good job of caching the value within DisasContext -- I imagine
that the final code wouldn't even change too much.

I see.  If this works out, I'll update my patch accordingly
-- please let me know.

I posted that on Monday:

20210629002930.3013776-1-richard.henderson@linaro.org/">https://patchew.org/QEMU/20210629002930.3013776-1-richard.henderson@linaro.org/

There are actually slightly fewer stores to the cc_op slot in the generated code, because some of them migrate to the helpers. But for normal integer code the generated *is* identical.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]